Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test-benchmark-buffer #15175

Closed
wants to merge 2 commits into from
Closed

test: add test-benchmark-buffer #15175

wants to merge 2 commits into from

Commits on Sep 4, 2017

  1. benchmark: add default configs to buffer benchmark 

    Add default values to use for `type` and `method` in `buffer` benchmarks
when the provided configuration value is an empty string. This is
primarily useful for testing, so the test can request a single iteration
without having to worry about providing different valid values for the
different benchmarks.

While making this change, some `var` instances in immediately
surrounding code were changed to `const`. In some cases, `var` had been
preserved so that the benchmarks would continue to run in versions of
Node.js prior to 4.0.0. However, now that `const` has been introduced
into the benchmark `common` module, the benchmarks will no longer run
with those versions of Node.js anyway.
    @Trott
    Trott committed Sep 4, 2017
    Copy the full SHA
    7e7d272 View commit details
    Browse the repository at this point in the history

  2. test: add test-benchmark-buffer 

    Add minimal test forbuffer benchmarks.
    @Trott
    Trott committed Sep 4, 2017
    Copy the full SHA
    ff792be View commit details
    Browse the repository at this point in the history