New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: turn key length exception into CHECK #15183

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@bnoordhuis
Member

bnoordhuis commented Sep 4, 2017

This exception can logically never happen because of the key stretching
that takes place first. Failure must therefore be a bug in Node.js and
not in the executing script.

src: turn key length exception into CHECK
This exception can logically never happen because of the key stretching
that takes place first.  Failure must therefore be a bug in Node.js and
not in the executing script.
@cjihrig

cjihrig approved these changes Sep 4, 2017

@jasnell

jasnell approved these changes Sep 5, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment

jasnell added a commit that referenced this pull request Sep 7, 2017

src: turn key length exception into CHECK
This exception can logically never happen because of the key stretching
that takes place first.  Failure must therefore be a bug in Node.js and
not in the executing script.

PR-URL: #15183
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 7, 2017

Member

Landed in 964beed

Member

jasnell commented Sep 7, 2017

Landed in 964beed

@jasnell jasnell closed this Sep 7, 2017

antoine-amara pushed a commit to antoine-amara/node that referenced this pull request Sep 7, 2017

src: turn key length exception into CHECK
This exception can logically never happen because of the key stretching
that takes place first.  Failure must therefore be a bug in Node.js and
not in the executing script.

PR-URL: nodejs#15183
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Sep 10, 2017

Member

This doesn't land cleanly on v8.x @bnoordhuis would you be able to backport?

Member

MylesBorins commented Sep 10, 2017

This doesn't land cleanly on v8.x @bnoordhuis would you be able to backport?

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Sep 10, 2017

Member

@MylesBorins #15037 should land before this PR (assuming it's to be back-ported - if not, I'll do a back-port.)

Member

bnoordhuis commented Sep 10, 2017

@MylesBorins #15037 should land before this PR (assuming it's to be back-ported - if not, I'll do a back-port.)

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Sep 10, 2017

Member

That worked, thanks!

Member

MylesBorins commented Sep 10, 2017

That worked, thanks!

MylesBorins added a commit that referenced this pull request Sep 10, 2017

src: turn key length exception into CHECK
This exception can logically never happen because of the key stretching
that takes place first.  Failure must therefore be a bug in Node.js and
not in the executing script.

PR-URL: #15183
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 10, 2017

Merged

v8.5.0 proposal #15308

MylesBorins added a commit that referenced this pull request Sep 11, 2017

src: turn key length exception into CHECK
This exception can logically never happen because of the key stretching
that takes place first.  Failure must therefore be a bug in Node.js and
not in the executing script.

PR-URL: #15183
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 11, 2017

src: turn key length exception into CHECK
This exception can logically never happen because of the key stretching
that takes place first.  Failure must therefore be a bug in Node.js and
not in the executing script.

PR-URL: #15183
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 12, 2017

src: turn key length exception into CHECK
This exception can logically never happen because of the key stretching
that takes place first.  Failure must therefore be a bug in Node.js and
not in the executing script.

PR-URL: #15183
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit to addaleax/node that referenced this pull request Sep 13, 2017

src: turn key length exception into CHECK
This exception can logically never happen because of the key stretching
that takes place first.  Failure must therefore be a bug in Node.js and
not in the executing script.

PR-URL: nodejs#15183
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Sep 20, 2017

Member

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Member

MylesBorins commented Sep 20, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Oct 29, 2017

src: turn key length exception into CHECK
This exception can logically never happen because of the key stretching
that takes place first.  Failure must therefore be a bug in Node.js and
not in the executing script.

PR-URL: nodejs#15183
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis
Member

bnoordhuis commented Oct 29, 2017

v6.x: #16585

@bnoordhuis bnoordhuis deleted the bnoordhuis:keylenchk branch Oct 29, 2017

MylesBorins added a commit that referenced this pull request Nov 14, 2017

src: turn key length exception into CHECK
This exception can logically never happen because of the key stretching
that takes place first.  Failure must therefore be a bug in Node.js and
not in the executing script.

Backport-PR-URL: #16585
PR-URL: #15183
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Nov 21, 2017

Merged

v6.12.1 proposal #17180

MylesBorins added a commit that referenced this pull request Nov 21, 2017

src: turn key length exception into CHECK
This exception can logically never happen because of the key stretching
that takes place first.  Failure must therefore be a bug in Node.js and
not in the executing script.

Backport-PR-URL: #16585
PR-URL: #15183
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Nov 28, 2017

src: turn key length exception into CHECK
This exception can logically never happen because of the key stretching
that takes place first.  Failure must therefore be a bug in Node.js and
not in the executing script.

Backport-PR-URL: #16585
PR-URL: #15183
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment