Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
http2: use session not socket timeout, tests #15188
This fixes #15158. Two changes included:
Marked as WIP as I think we need to investigate whether socket timeout is necessary anywhere and also because this needs a lot more tests, ideally.
Affected core subsystem(s)
@mcollina It's not too bad after all.
Not too surprising that there's a tiny bit of a hit since before this PR the timeouts were completely bugged and weren't doing anything (basically no-op). Same benchmark with
Edit: This is after 40 runs on each node version btw.
CI is definitely not green on this one: https://ci.nodejs.org/job/node-test-commit-linuxone/8427/nodes=rhel72-s390x/console
@apapirovski ... can you take a look?
btw, I really appreciate that you've jumped in on these. PR's from new contributors make me super happy :-)