New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test, build: Clean up package-lock.json after make coverage #15196

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
9 participants
@ssbrewster
Contributor

ssbrewster commented Sep 5, 2017

When running make coverage, npm installs istanbul-merge and nyc and
generates a package-lock.json file.

This PR adds the rm package-lock.json command to the Makefile.

Refs: https://github.com/nodejs/node/pull/15190/files#r136932786

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@ssbrewster ssbrewster changed the title from test: Clean up package-lock.json after make coverage to test, build: Clean up package-lock.json after make coverage Sep 5, 2017

@cjihrig

cjihrig approved these changes Sep 5, 2017

@jasnell

jasnell approved these changes Sep 5, 2017

@lpinca

This comment has been minimized.

Member

lpinca commented Sep 5, 2017

Isn't better to use the --no-package-lock flag?

@Fishrock123

This comment has been minimized.

Member

Fishrock123 commented Sep 5, 2017

Yeah I think --no-package-lock on the install would be more appropriate here overall.

@Fishrock123

This comment has been minimized.

Member

Fishrock123 commented Sep 5, 2017

Actually, relatedly, since npm now saves by default, make coverage should probably have --no-save(?) too.

ssbrewster added some commits Sep 5, 2017

test: Clean up package-lock.json after coverage
When running make coverage npm installs istanbul-merge and nyc and
generates a package-lock.json file

Ensure this file is removed when running make coverage-clean

Refs: https://github.com/nodejs/node/pull/15190/files#r136932786
test: use no-save and no-package-lock flags
Use these flags when running make coverage so that a package-lock.json
file is not generated and npm does not attempt to save the deps to a
non-existent package.json file

Refs: https://github.com/nodejs/node/pull/15190/files#r136932786
@ssbrewster

This comment has been minimized.

Contributor

ssbrewster commented Sep 6, 2017

Thanks for mentioning those flags @lpinca @Fishrock123. PR updated.

@lpinca

lpinca approved these changes Sep 6, 2017

@BridgeAR

This comment has been minimized.

Member

BridgeAR commented Sep 8, 2017

@ssbrewster thanks a lot for your contribution!

Landed in 9168b8c

@BridgeAR BridgeAR closed this Sep 8, 2017

BridgeAR added a commit that referenced this pull request Sep 8, 2017

test: use no-save and no-package-lock flags
Use these flags when running make coverage so that a package-lock.json
file is not generated and npm does not attempt to save the deps to a
non-existent package.json file.

PR-URL: #15196
Refs: https://github.com/nodejs/node/pull/15190/files#r136932786
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@ssbrewster ssbrewster deleted the ssbrewster:coverage-clean-pkg-lock branch Sep 8, 2017

MylesBorins added a commit that referenced this pull request Sep 10, 2017

test: use no-save and no-package-lock flags
Use these flags when running make coverage so that a package-lock.json
file is not generated and npm does not attempt to save the deps to a
non-existent package.json file.

PR-URL: #15196
Refs: https://github.com/nodejs/node/pull/15190/files#r136932786
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@MylesBorins MylesBorins referenced this pull request Sep 10, 2017

Merged

v8.5.0 proposal #15308

MylesBorins added a commit that referenced this pull request Sep 11, 2017

test: use no-save and no-package-lock flags
Use these flags when running make coverage so that a package-lock.json
file is not generated and npm does not attempt to save the deps to a
non-existent package.json file.

PR-URL: #15196
Refs: https://github.com/nodejs/node/pull/15190/files#r136932786
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Sep 12, 2017

test: use no-save and no-package-lock flags
Use these flags when running make coverage so that a package-lock.json
file is not generated and npm does not attempt to save the deps to a
non-existent package.json file.

PR-URL: #15196
Refs: https://github.com/nodejs/node/pull/15190/files#r136932786
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

addaleax added a commit to addaleax/node that referenced this pull request Sep 13, 2017

test: use no-save and no-package-lock flags
Use these flags when running make coverage so that a package-lock.json
file is not generated and npm does not attempt to save the deps to a
non-existent package.json file.

PR-URL: nodejs#15196
Refs: https://github.com/nodejs/node/pull/15190/files#r136932786
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins

This comment has been minimized.

Member

MylesBorins commented Sep 20, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

@ssbrewster

This comment has been minimized.

Contributor

ssbrewster commented Sep 21, 2017

@MylesBorins what is the criteria for backporting? Happy to raise a PR if needed.

@lpinca

This comment has been minimized.

@lpinca

This comment has been minimized.

Member

lpinca commented Sep 21, 2017

I actually realized you asked another thing, sorry. I see no coverage target on v6.x Makefile so I think this should not be backported.

@ssbrewster

This comment has been minimized.

Contributor

ssbrewster commented Sep 21, 2017

Ok thanks for the confirmation @lpinca 😄

@lpinca

This comment has been minimized.

Member

lpinca commented Sep 21, 2017

Added dont-land label, sorry again for the confusion @ssbrewster.

@ssbrewster

This comment has been minimized.

Contributor

ssbrewster commented Sep 21, 2017

No worries @lpinca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment