New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6.x] deps: backport 071b655 from V8 upstream #15215

Closed
wants to merge 2 commits into
base: v6.x-staging
from

Conversation

Projects
None yet
8 participants
@targos
Member

targos commented Sep 6, 2017

Original commit message:

[PATCH] [debugger] Scope iterator should not visit inner function literals.

R=marja@chromium.org
BUG=chromium:621361

Review-Url: https://codereview.chromium.org/2185913003
Cr-Commit-Position: refs/heads/master@{#38087}

Fixes: #15075

/cc @nodejs/v8 @hashseed

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

V8

deps: backport 071b655 from V8 upstream
Original commit message:

    [PATCH] [debugger] Scope iterator should not visit inner function literals.

    R=marja@chromium.org
    BUG=chromium:621361

    Review-Url: https://codereview.chromium.org/2185913003
    Cr-Commit-Position: refs/heads/master@{#38087}

Fixes: #15075

@targos targos changed the title from deps: backport 071b655 from V8 upstream to [v6.x] deps: backport 071b655 from V8 upstream Sep 6, 2017

@cjihrig

cjihrig approved these changes Sep 6, 2017

@jasnell

jasnell approved these changes Sep 6, 2017

@mhdawson

LGTM

MylesBorins added a commit that referenced this pull request Sep 19, 2017

deps: backport 071b655 from V8 upstream
Original commit message:

    [PATCH] [debugger] Scope iterator should not visit inner function literals.

    R=marja@chromium.org
    BUG=chromium:621361

    Review-Url: https://codereview.chromium.org/2185913003
    Cr-Commit-Position: refs/heads/master@{#38087}

Fixes: #15075

PR-URL: #15215
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Sep 19, 2017

Member

landed in 921876d

Member

MylesBorins commented Sep 19, 2017

landed in 921876d

@targos targos deleted the targos:fix-15075 branch Sep 19, 2017

@MylesBorins MylesBorins referenced this pull request Sep 20, 2017

Merged

v6.11.4 proposal #15506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment