Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: expand http2 maxSendHeaderBlockLength test case #15298

Closed

Conversation

Projects
None yet
7 participants
@apapirovski
Copy link
Member

commented Sep 9, 2017

Just a tiny change to expand maxSendHeaderBlockLength test to check what happens if frameError listener isn't available.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@mscdex mscdex added the http2 label Sep 9, 2017

})(err);
req2.on('error', common.expectsError({
code: 'ERR_HTTP2_STREAM_ERROR',
message: 'Stream closed with error code 7'

This comment has been minimized.

Copy link
@BridgeAR

BridgeAR Sep 13, 2017

Member

It is always a good idea to add the type as well.

@jasnell

This comment has been minimized.

@jasnell

This comment has been minimized.

Copy link
Member

commented Sep 15, 2017

@apapirovski ... can you address @BridgeAR's comment? Then I'll get this landed.

test: expand http2 frameError test case
Expand maxSendHeaderBlockLength test to check what happens if
frameError listener isn't available.

@apapirovski apapirovski force-pushed the apapirovski:patch-http2-framerror-handling branch from 6f529c8 to ac192b1 Sep 15, 2017

@apapirovski

This comment has been minimized.

Copy link
Member Author

commented Sep 15, 2017

Thanks @BridgeAR & @jasnell — updated now.

@jasnell

This comment has been minimized.

Copy link
Member

commented Sep 15, 2017

@apapirovski

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2017

Failures in arm-fanned seem unrelated?

@BridgeAR

This comment has been minimized.

Copy link
Member

commented Sep 19, 2017

@apapirovski they are definitely unrelated. I think that test is already fixed / there is a open PR to fix that one.

not ok 50 parallel/test-dgram-multicast-set-interface
  ---
  duration_ms: 2.252
  severity: fail
  stack: |-
    1..0 # Skipped: Skipping udp6 tests, no IPv6 support.
    Mismatched <anonymous> function calls. Expected exactly 1, actual 0.
        at Object.exports.mustCall (/home/iojs/build/workspace/node-test-binary-arm/test/common/index.js:482:10)
        at Object.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-dgram-multicast-set-interface.js:10:33)
@refack

refack approved these changes Sep 19, 2017

@BridgeAR

This comment has been minimized.

Copy link
Member

commented Sep 20, 2017

Landed in 15879ad

@BridgeAR BridgeAR closed this Sep 20, 2017

BridgeAR added a commit that referenced this pull request Sep 20, 2017

test: expand http2 frameError test case
Expand maxSendHeaderBlockLength test to check what happens if
frameError listener isn't available.

PR-URL: #15298
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>

jasnell added a commit that referenced this pull request Sep 20, 2017

test: expand http2 frameError test case
Expand maxSendHeaderBlockLength test to check what happens if
frameError listener isn't available.

PR-URL: #15298
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@apapirovski apapirovski deleted the apapirovski:patch-http2-framerror-handling branch Sep 20, 2017

Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017

test: expand http2 frameError test case
Expand maxSendHeaderBlockLength test to check what happens if
frameError listener isn't available.

PR-URL: nodejs/node#15298
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>

Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017

test: expand http2 frameError test case
Expand maxSendHeaderBlockLength test to check what happens if
frameError listener isn't available.

PR-URL: nodejs/node#15298
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.