Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing heading for error #15325

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
10 participants
@maclover7
Copy link
Member

commented Sep 11, 2017

Checklist
Affected core subsystem(s)

doc

@Trott

Trott approved these changes Sep 11, 2017

Copy link
Member

left a comment

LGTM. (I also don't think this needs to wait the full 48/72 hours before landing, although it might be good to amass four or five approvals before landing.)

@lpinca

lpinca approved these changes Sep 11, 2017

@BridgeAR

This comment has been minimized.

Copy link
Member

commented Sep 13, 2017

Landed in f68ab39

@BridgeAR BridgeAR closed this Sep 13, 2017

BridgeAR added a commit that referenced this pull request Sep 13, 2017

doc: add missing heading for error
PR-URL: #15325
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@maclover7 maclover7 deleted the maclover7:jm-doc-heading branch Sep 14, 2017

addaleax added a commit to addaleax/ayo that referenced this pull request Sep 17, 2017

doc: add missing heading for error
PR-URL: nodejs/node#15325
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

jasnell added a commit that referenced this pull request Sep 20, 2017

doc: add missing heading for error
PR-URL: #15325
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017

doc: add missing heading for error
PR-URL: nodejs/node#15325
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.