Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove unused perf_hooks uv handles #15368

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@jasnell
Copy link
Member

commented Sep 12, 2017

A couple of unused uv handles were accidentally left in env.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

src: remove unused perf_hooks uv handles
A couple of unused uv handles were accidentally left
in env.
@mscdex

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2017

@addaleax

This comment has been minimized.

Copy link
Member

commented Sep 13, 2017

CI looks good, I don’t think this needs to wait 48 hours

jasnell added a commit that referenced this pull request Sep 13, 2017

src: remove unused perf_hooks uv handles
A couple of unused uv handles were accidentally left
in env.

PR-URL: #15368
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2017

Landed in dcc41fd

@jasnell jasnell closed this Sep 13, 2017

addaleax added a commit to addaleax/ayo that referenced this pull request Sep 17, 2017

src: remove unused perf_hooks uv handles
A couple of unused uv handles were accidentally left
in env.

PR-URL: nodejs/node#15368
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>

jasnell added a commit that referenced this pull request Sep 20, 2017

src: remove unused perf_hooks uv handles
A couple of unused uv handles were accidentally left
in env.

PR-URL: #15368
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>

Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017

src: remove unused perf_hooks uv handles
A couple of unused uv handles were accidentally left
in env.

PR-URL: nodejs/node#15368
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.