Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: cherry-pick 989d7b9 from upstream V8 #15383

Closed
wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Sep 13, 2017

Original commit message:

[error] Lazy stack trace formatting for Error.captureStackTrace

This reinstates the old behavior of Error.captureStackTrace prior to
4feafee9d9.  Like the builtin Error constructors, captureStackTrace now formats
the stack trace lazily once it is accessed.

Bug: v8:5962
Change-Id: I03821b73d26b7b40809a1fea98f9c820bfa05d6b
Reviewed-on: https://chromium-review.googlesource.com/574530
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46727}

Fixes: #13048
Fixes: #11343

/cc @nodejs/v8

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

V8

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Sep 13, 2017
@MikeRalphson
Copy link
Contributor

MikeRalphson commented Sep 13, 2017

Many thanks @targos ! I believe this will also fix #11343

Also - did any of the performance test-suite show an improvement with this commit? Otherwise we would seem to have an area which is not covered in case of future regressions. Happy to submit a PR.

Original commit message:

    [error] Lazy stack trace formatting for Error.captureStackTrace

    This reinstates the old behavior of Error.captureStackTrace prior to
    4feafee9d9.  Like the builtin Error constructors, captureStackTrace now formats
    the stack trace lazily once it is accessed.

    Bug: v8:5962
    Change-Id: I03821b73d26b7b40809a1fea98f9c820bfa05d6b
    Reviewed-on: https://chromium-review.googlesource.com/574530
    Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{nodejs#46727}

Fixes: nodejs#13048
Fixes: nodejs#11343
@targos
Copy link
Member Author

targos commented Sep 13, 2017

@targos
Copy link
Member Author

targos commented Sep 13, 2017

There is something wrong with the PPC machines:

Fetching V8 from chromium.googlesource.com
Error: Command 'download_from_google_storage --no_resume --platform=linux* --no_auth --bucket chromium-clang-format -s v8/buildtools/linux64/clang-format.sha1' returned non-zero exit status 1 in /home/iojs/build/workspace/node-test-commit-v8-linux/nodes/ppcbe-ubuntu1404/v8test/v8test/deps

@jasnell
Copy link
Member

jasnell commented Sep 15, 2017

@targos ... can you rebase this?

@targos
Copy link
Member Author

targos commented Sep 18, 2017

This commit is already present in V8 6.1. We can close this.

@targos targos closed this Sep 18, 2017
@targos targos deleted the fix-13048 branch September 18, 2017 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants