Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix entryTypes type and missing link in perf_hooks.md #15406

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
8 participants
@manidlou
Copy link
Contributor

commented Sep 14, 2017

Fixed entryTypes in performance.timerify(fn) example and async_hooks missing link in perf_hooks.md.

Checklist
Affected core subsystem(s)

doc

@@ -656,3 +656,4 @@ require('some-module');

[`timeOrigin`]: https://w3c.github.io/hr-time/#dom-performance-timeorigin
[W3C Performance Timeline]: https://w3c.github.io/performance-timeline/
[Async Hooks]: async_hooks.html

This comment has been minimized.

Copy link
@lpinca

lpinca Sep 14, 2017

Member

Can you please swap this with the previous line to keep them sorted alphabetically?

This comment has been minimized.

Copy link
@manidlou

manidlou Sep 14, 2017

Author Contributor

Absolutely. Just to make sure, you mean

case 1:
a. timeOrigin
b. Async Hooks
c. W3C Performance Timeline

or case 2
a. Async Hooks
b. timeOrigin
c. W3C Performance Timeline
?

This comment has been minimized.

Copy link
@cjihrig

cjihrig Sep 14, 2017

Contributor

@manidlou, case 1. Thanks.

@lpinca

lpinca approved these changes Sep 14, 2017

@manidlou

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2017

Can you please swap this with the previous line to keep them sorted alphabetically?

Done.

@daxlab

daxlab approved these changes Sep 16, 2017

BridgeAR added a commit to BridgeAR/node that referenced this pull request Sep 19, 2017

doc: fix entryTypes type and missing link
PR-URL: nodejs#15406
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

This comment has been minimized.

Copy link
Member

commented Sep 19, 2017

@manidlou thanks a lot for your contribution and congratulations on your first commit to Node.js! 🎉

Landed in 049a8d7

@BridgeAR BridgeAR closed this Sep 19, 2017

jasnell added a commit that referenced this pull request Sep 20, 2017

doc: fix entryTypes type and missing link
PR-URL: #15406
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017

doc: fix entryTypes type and missing link
PR-URL: nodejs/node#15406
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017

doc: fix entryTypes type and missing link
PR-URL: nodejs/node#15406
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.