Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fs: refactor close to use destroy #15407
Refactor close() to use destroy() and not vice versa in ReadStream.
Affected core subsystem(s)
I was not able to write a test for the given issue, but I am fairly certain that this solves the problem.
I am not really able to write a test to reproduce the change of behavior, which should stay fairly the same. I have flagged this as semver-major as I fear it might introduce bugs and regressions.
A CITGM run might help.
referenced this pull request
Sep 14, 2017
I would like this to land in Node 9 if possible.
cc @nodejs/tsc for another approval as it's semver-major.
@mcollina the citgm results between this PR and master don't look too far off, but I will say that there is now a huge delta between 8.x and 9.x on citgm which is a bit disturbing. Can't dig into it today but we should figure out what shifted on master to break so many things
@mcollina I didn't see anything new in CitGM