New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: prevent displaying empty version picker #15420

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@chris--young
Contributor

chris--young commented Sep 14, 2017

This will prevent an empty drop down from being displayed when pages do not have multiple version to choose from

Fixes: #15396

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc, tools

@jasnell

Rubber stamp LGTM

@refack

refack approved these changes Sep 15, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Sep 15, 2017

Member

@chris--young Thanks!
If it's not too much work, could you run the tool pre and post PR and upload a sample page (e.g. n-api.html) as a gist?

Member

refack commented Sep 15, 2017

@chris--young Thanks!
If it's not too much work, could you run the tool pre and post PR and upload a sample page (e.g. n-api.html) as a gist?

@chris--young

This comment has been minimized.

Show comment
Hide comment
@chris--young

chris--young Sep 15, 2017

Contributor

@refack for sure

pre
post

the difference is around line 95

Contributor

chris--young commented Sep 15, 2017

@refack for sure

pre
post

the difference is around line 95

@BridgeAR

This comment has been minimized.

Show comment
Hide comment
@BridgeAR

BridgeAR Sep 19, 2017

Member

@chris--young thanks a lot!

Landed in 2b7b9f2

Member

BridgeAR commented Sep 19, 2017

@chris--young thanks a lot!

Landed in 2b7b9f2

@BridgeAR BridgeAR closed this Sep 19, 2017

BridgeAR added a commit that referenced this pull request Sep 19, 2017

doc: prevent displaying empty version picker
PR-URL: #15420
Fixes: #15396
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

jasnell added a commit that referenced this pull request Sep 20, 2017

doc: prevent displaying empty version picker
PR-URL: #15420
Fixes: #15396
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@refack refack referenced this pull request Sep 20, 2017

Closed

doc: add links to alternative versions of doc #10958

3 of 3 tasks complete

Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017

doc: prevent displaying empty version picker
PR-URL: nodejs/node#15420
Fixes: nodejs/node#15396
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

chris--young added a commit to chris--young/node that referenced this pull request Sep 29, 2017

doc: prevent displaying empty version picker
PR-URL: nodejs#15420
Fixes: nodejs#15396
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

chris--young added a commit to chris--young/node that referenced this pull request Sep 29, 2017

doc: prevent displaying empty version picker
PR-URL: nodejs#15420
Fixes: nodejs#15396
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins added a commit that referenced this pull request Sep 29, 2017

doc: prevent displaying empty version picker
Backport-PR-URL: #15670
PR-URL: #15420
Fixes: #15396
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@MylesBorins MylesBorins referenced this pull request Sep 29, 2017

Merged

v6.11.4 proposal #15506

addaleax added a commit to addaleax/ayo that referenced this pull request Oct 12, 2017

doc: prevent displaying empty version picker
PR-URL: nodejs/node#15420
Fixes: nodejs/node#15396
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment