New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib: migrate to internal/errors #15618

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@jasnell
Member

jasnell commented Sep 25, 2017

Migrate zlib to use internal/errors

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

zlib, errors

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell
Member

jasnell commented Sep 25, 2017

@jasnell jasnell requested review from fhinkel, addaleax and mhdawson Sep 25, 2017

@BridgeAR

LGTM

Show outdated Hide outdated lib/zlib.js Outdated
@lpinca

lpinca approved these changes Sep 26, 2017

@jasnell jasnell referenced this pull request Sep 28, 2017

Closed

Tracking Issue: Migrate errors to internal/errors.js #11273

78 of 80 tasks complete

@BridgeAR BridgeAR requested a review from nodejs/tsc Sep 28, 2017

@BridgeAR

This comment has been minimized.

Show comment
Hide comment
@BridgeAR

BridgeAR Sep 28, 2017

Member

@nodejs/tsc this needs some LGs

Member

BridgeAR commented Sep 28, 2017

@nodejs/tsc this needs some LGs

@mhdawson

This looks good except that its missing adding the tests for the new errors in: test/parallel/test-internal-errors.js

See https://github.com/nodejs/node/blob/master/doc/guides/using-internal-errors.md#testing-new-errorss

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Oct 2, 2017

Member

@jasnell can you add the tests for the new errors which are not constants.

Member

mhdawson commented Oct 2, 2017

@jasnell can you add the tests for the new errors which are not constants.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 2, 2017

Member

@mhdawson, added

Member

jasnell commented Oct 2, 2017

@mhdawson, added

@jasnell

This comment has been minimized.

Show comment
Hide comment
@mhdawson

lgtm

jasnell added a commit that referenced this pull request Oct 2, 2017

zlib: migrate to internal/errors
PR-URL: #15618
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 2, 2017

Member

Landed in 7489141

Member

jasnell commented Oct 2, 2017

Landed in 7489141

@jasnell jasnell closed this Oct 2, 2017

addaleax added a commit to addaleax/ayo that referenced this pull request Oct 4, 2017

zlib: migrate to internal/errors
PR-URL: nodejs/node#15618
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment