New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector: migrate to internal/errors #15619

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@jasnell
Member

jasnell commented Sep 26, 2017

migrate to internal/errors

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

inspector,errors

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell
Member

jasnell commented Sep 26, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca approved these changes Sep 26, 2017

Show outdated Hide outdated lib/inspector.js Outdated
@BridgeAR

This comment has been minimized.

Show comment
Hide comment
@BridgeAR

BridgeAR Sep 26, 2017

Member

Do we not have any tests for the inspector error cases?

Member

BridgeAR commented Sep 26, 2017

Do we not have any tests for the inspector error cases?

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 26, 2017

Member

@BridgeAR ... none that were affected... which is a bit scary.

Member

jasnell commented Sep 26, 2017

@BridgeAR ... none that were affected... which is a bit scary.

@BridgeAR

This comment has been minimized.

Show comment
Hide comment
@BridgeAR

BridgeAR Sep 28, 2017

Member

@jasnell would you be so kind and add some for those? I think it would be a shame not to use the opportunity otherwise.

Member

BridgeAR commented Sep 28, 2017

@jasnell would you be so kind and add some for those? I think it would be a shame not to use the opportunity otherwise.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Sep 28, 2017

Member

Sure :-) gimme a couple of days tho.

Member

jasnell commented Sep 28, 2017

Sure :-) gimme a couple of days tho.

@jasnell jasnell referenced this pull request Sep 28, 2017

Closed

Tracking Issue: Migrate errors to internal/errors.js #11273

78 of 80 tasks complete
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 2, 2017

Member

Test added!

Member

jasnell commented Oct 2, 2017

Test added!

@jasnell jasnell requested a review from nodejs/tsc Oct 2, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 13, 2017

Member

Ping @nodejs/tsc ... review please?

Member

jasnell commented Oct 13, 2017

Ping @nodejs/tsc ... review please?

@jasnell

This comment has been minimized.

Show comment
Hide comment
@ofrobots

LGTM, Thanks!

Show outdated Hide outdated lib/internal/errors.js Outdated

jasnell added a commit that referenced this pull request Oct 16, 2017

inspector: migrate to internal/errors
PR-URL: #15619
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 16, 2017

Member

Landed in 4cf56ad

Member

jasnell commented Oct 16, 2017

Landed in 4cf56ad

@jasnell jasnell closed this Oct 16, 2017

addaleax added a commit to ayojs/ayo that referenced this pull request Oct 18, 2017

inspector: migrate to internal/errors
PR-URL: nodejs/node#15619
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment