Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update es-module.status prefix #15690

Closed
wants to merge 1 commit into from

Conversation

@jackhorton
Copy link
Contributor

jackhorton commented Sep 29, 2017

We noticed this error while taking in changes for node-chakracore.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@Trott
Trott approved these changes Sep 30, 2017
Copy link
Member

Trott left a comment

LGTM. This shouldn't need to wait the full 72 hours before landing IMO.

@Trott

This comment has been minimized.

@lpinca
lpinca approved these changes Sep 30, 2017
@TimothyGu

This comment has been minimized.

Copy link
Member

TimothyGu commented Sep 30, 2017

My bad. Thanks for taking care of this!

@jasnell
jasnell approved these changes Oct 1, 2017
Copy link
Member

jasnell left a comment

Not sure this needs to wait the 48 hours to land

Trott added a commit to Trott/io.js that referenced this pull request Oct 1, 2017
PR-URL: nodejs#15690
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

Trott commented Oct 1, 2017

Landed in 0880293. Thanks for the fix!

@Trott Trott closed this Oct 1, 2017
@jackhorton jackhorton deleted the jackhorton:es-module-status branch Oct 2, 2017
MylesBorins added a commit that referenced this pull request Oct 3, 2017
PR-URL: #15690
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
MylesBorins added a commit that referenced this pull request Oct 3, 2017
PR-URL: #15690
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
PR-URL: nodejs/node#15690
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Oct 11, 2017
PR-URL: #15690
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.