New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade libuv to 1.15.0 #15745

Merged
merged 1 commit into from Oct 5, 2017

Conversation

Projects
None yet
10 participants
@cjihrig
Contributor

cjihrig commented Oct 3, 2017

Notable Changes

  • A lot of work toward NetBSD support.
  • Several bug fixes for uv_fs_copyfile(), which is used by fs.copyFile().
  • Updated UV_PROCESS_WINDOWS_HIDE to hide console windows.

Refs: #15380
Refs: #15683
Fixes: #15394

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

@mscdex

This comment has been minimized.

Show comment
Hide comment
Contributor

mscdex commented Oct 3, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 3, 2017

Member

Can you provide a summary of the key changes in the PR text above?

Member

jasnell commented Oct 3, 2017

Can you provide a summary of the key changes in the PR text above?

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Oct 3, 2017

Contributor

CI looks good. Only failures appear to be related to #14404 and #15558.

Contributor

cjihrig commented Oct 3, 2017

CI looks good. Only failures appear to be related to #14404 and #15558.

@jasnell

jasnell approved these changes Oct 3, 2017

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Oct 3, 2017

Contributor

I've added some notable changes and linked to some issues for the PR metadata. To be honest, there isn't a ton that Node should care too much about, although @evanlucas might be interested to see that @bnoordhuis picked up libuv/libuv#641.

Contributor

cjihrig commented Oct 3, 2017

I've added some notable changes and linked to some issues for the PR metadata. To be honest, there isn't a ton that Node should care too much about, although @evanlucas might be interested to see that @bnoordhuis picked up libuv/libuv#641.

@refack

refack approved these changes Oct 3, 2017

@evanlucas

This comment has been minimized.

Show comment
Hide comment
@evanlucas

evanlucas Oct 3, 2017

Member

Thanks @bnoordhuis! I couldn't quite get it right :].

Member

evanlucas commented Oct 3, 2017

Thanks @bnoordhuis! I couldn't quite get it right :].

@santigimeno

This comment has been minimized.

Show comment
Hide comment
@santigimeno

santigimeno Oct 5, 2017

Member

It fixes: #15770 too

Member

santigimeno commented Oct 5, 2017

It fixes: #15770 too

deps: upgrade libuv to 1.15.0
Refs: #15380
Refs: #15683
Fixes: #15394
Fixes: #15770
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@cjihrig cjihrig merged commit 75318e4 into nodejs:master Oct 5, 2017

@cjihrig cjihrig deleted the cjihrig:libuv branch Oct 5, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Oct 5, 2017

Member

@cjihrig There's no PR-URL on this commit message. (core-validate-commit FTW as usual!)

Member

Trott commented on 75318e4 Oct 5, 2017

@cjihrig There's no PR-URL on this commit message. (core-validate-commit FTW as usual!)

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex Oct 9, 2017

Contributor

PR-URL is: #15745

Contributor

mscdex replied Oct 9, 2017

PR-URL is: #15745

Trott added a commit to Trott/io.js that referenced this pull request Oct 5, 2017

deps: upgrade libuv to 1.15.0
PR-URL: nodejs#15745
Refs: nodejs#15380
Refs: nodejs#15683
Fixes: nodejs#15394
Fixes: nodejs#15770
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Oct 5, 2017

Member

Force pushed fca6c58 to add the missing metadata.

Member

Trott commented Oct 5, 2017

Force pushed fca6c58 to add the missing metadata.

MylesBorins added a commit that referenced this pull request Oct 7, 2017

deps: upgrade libuv to 1.15.0
PR-URL: #15745
Refs: #15380
Refs: #15683
Fixes: #15394
Fixes: #15770
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@mattiash mattiash referenced this pull request Oct 10, 2017

Closed

Issue 14736 tls ipv6 address #14772

3 of 4 tasks complete

MylesBorins added a commit that referenced this pull request Oct 11, 2017

deps: upgrade libuv to 1.15.0
PR-URL: #15745
Refs: #15380
Refs: #15683
Fixes: #15394
Fixes: #15770
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 11, 2017

2017-10-11, Node.js Version 8.7.0 (Current)
Notable Changes:

* deps:
  * update npm to 5.4.2
    #15600
  * upgrade libuv to 1.15.0
    #15745
  * update V8 to 6.1.534.42
    #15393
* dgram:
  * support for setting dgram socket buffer size
    #13623
* fs:
  * add support O_DSYNC file open constant
    #15451
* util:
  * deprecate obj.inspect for custom inspection
    #15631
* tools, build:
  * there is a fancy new macOS installer
    #15179
* Added new collaborator
  * bmeurer - Benedikt Meurer - https://github.com/bmeurer
  * kfarnung - Kyle Farnung - https://github.com/kfarnung

PR-URL: #15762

MylesBorins added a commit that referenced this pull request Oct 11, 2017

2017-10-11, Node.js Version 8.7.0 (Current)
Notable Changes:

* deps:
  * update npm to 5.4.2
    #15600
  * upgrade libuv to 1.15.0
    #15745
  * update V8 to 6.1.534.42
    #15393
* dgram:
  * support for setting dgram socket buffer size
    #13623
* fs:
  * add support O_DSYNC file open constant
    #15451
* util:
  * deprecate obj.inspect for custom inspection
    #15631
* tools, build:
  * there is a fancy new macOS installer
    #15179
* Added new collaborator
  * bmeurer - Benedikt Meurer - https://github.com/bmeurer
  * kfarnung - Kyle Farnung - https://github.com/kfarnung

PR-URL: #15762

addaleax added a commit to addaleax/ayo that referenced this pull request Oct 12, 2017

deps: upgrade libuv to 1.15.0
PR-URL: nodejs/node#15745
Refs: nodejs/node#15380
Refs: nodejs/node#15683
Fixes: nodejs/node#15394
Fixes: nodejs/node#15770
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit to addaleax/ayo that referenced this pull request Oct 12, 2017

2017-10-11, Node.js Version 8.7.0 (Current)
Notable Changes:

* deps:
  * update npm to 5.4.2
    nodejs/node#15600
  * upgrade libuv to 1.15.0
    nodejs/node#15745
  * update V8 to 6.1.534.42
    nodejs/node#15393
* dgram:
  * support for setting dgram socket buffer size
    nodejs/node#13623
* fs:
  * add support O_DSYNC file open constant
    nodejs/node#15451
* util:
  * deprecate obj.inspect for custom inspection
    nodejs/node#15631
* tools, build:
  * there is a fancy new macOS installer
    nodejs/node#15179
* Added new collaborator
  * bmeurer - Benedikt Meurer - https://github.com/bmeurer
  * kfarnung - Kyle Farnung - https://github.com/kfarnung

PR-URL: nodejs/node#15762
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Oct 16, 2017

Member

Do we want to include this in the upcoming 6.x LTS minor? It may be the last minor for the 6.x release line. That being said I don't want to rush ti if this could potentially complicate things

/cc @nodejs/tsc @nodejs/lts

Member

MylesBorins commented Oct 16, 2017

Do we want to include this in the upcoming 6.x LTS minor? It may be the last minor for the 6.x release line. That being said I don't want to rush ti if this could potentially complicate things

/cc @nodejs/tsc @nodejs/lts

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Oct 16, 2017

Contributor

I think this would be good to get into Node 6 due to the mentioned notable changes. I understand if people don't want to rush it though.

Contributor

cjihrig commented Oct 16, 2017

I think this would be good to get into Node 6 due to the mentioned notable changes. I understand if people don't want to rush it though.

@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex Oct 16, 2017

Contributor

Are we sure that recent versions of libuv still work on all of the platforms supported by node v6.x?

Contributor

mscdex commented Oct 16, 2017

Are we sure that recent versions of libuv still work on all of the platforms supported by node v6.x?

@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Oct 16, 2017

Contributor

As of 1.12.0, it was safe to backport. I just looked through the Changelog since then, and it still appears to be the case. Perhaps @bnoordhuis can confirm though.

Contributor

cjihrig commented Oct 16, 2017

As of 1.12.0, it was safe to backport. I just looked through the Changelog since then, and it still appears to be the case. Perhaps @bnoordhuis can confirm though.

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Oct 17, 2017

Member

Yes, no legacy code has been removed so far.

Member

bnoordhuis commented Oct 17, 2017

Yes, no legacy code has been removed so far.

MylesBorins added a commit that referenced this pull request Oct 17, 2017

deps: upgrade libuv to 1.15.0
PR-URL: #15745
Refs: #15380
Refs: #15683
Fixes: #15394
Fixes: #15770
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 17, 2017

Merged

v6.12.0 proposal #16263

MylesBorins added a commit that referenced this pull request Oct 25, 2017

deps: upgrade libuv to 1.15.0
PR-URL: #15745
Refs: #15380
Refs: #15683
Fixes: #15394
Fixes: #15770
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Nov 3, 2017

Merged

v4.8.6 proposal #16500

MylesBorins added a commit that referenced this pull request Nov 6, 2017

2017-11-07, Version 6.12.0 'Boron' (LTS)
Notable Changes:

* assert:
  - assert.fail() can now take one or two arguments (Rich Trott)
    #12293
* crypto:
  - add sign/verify support for RSASSA-PSS (Tobias Nießen)
    #11705
* deps:
  - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
    #16691
  - upgrade libuv to 1.15.0 (cjihrig)
    #15745
  - upgrade libuv to 1.14.1 (cjihrig)
    #14866
  - upgrade libuv to 1.13.1 (cjihrig)
    #14117
  - upgrade libuv to 1.12.0 (cjihrig)
    #13306
* fs:
  - Add support for fs.write/fs.writeSync(fd, buffer, cb) and
    fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
    (Andreas Lind) #7856
* inspector:
  - enable --inspect-brk (Refael Ackermann)
    #12615
* process:
  - add --redirect-warnings command line argument (James M Snell)
    #10116
* src:
  - allow CLI args in env with NODE_OPTIONS (Sam Roberts)
    #12028)
  - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
    #13932
  - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
    #13172
  - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
    #12677
* test:
  - remove common.fail() (Rich Trott)
    #12293

PR-URL: #16263

MylesBorins added a commit that referenced this pull request Nov 7, 2017

2017-11-07, Version 6.12.0 'Boron' (LTS)
Notable Changes:

* assert:
  - assert.fail() can now take one or two arguments (Rich Trott)
    #12293
* crypto:
  - add sign/verify support for RSASSA-PSS (Tobias Nießen)
    #11705
* deps:
  - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
    #16691
  - upgrade libuv to 1.15.0 (cjihrig)
    #15745
  - upgrade libuv to 1.14.1 (cjihrig)
    #14866
  - upgrade libuv to 1.13.1 (cjihrig)
    #14117
  - upgrade libuv to 1.12.0 (cjihrig)
    #13306
* fs:
  - Add support for fs.write/fs.writeSync(fd, buffer, cb) and
    fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
    (Andreas Lind) #7856
* inspector:
  - enable --inspect-brk (Refael Ackermann)
    #12615
* process:
  - add --redirect-warnings command line argument (James M Snell)
    #10116
* src:
  - allow CLI args in env with NODE_OPTIONS (Sam Roberts)
    #12028)
  - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
    #13932
  - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
    #13172
  - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
    #12677
* test:
  - remove common.fail() (Rich Trott)
    #12293

PR-URL: #16263

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

2017-11-07, Version 6.12.0 'Boron' (LTS)
Notable Changes:

* assert:
  - assert.fail() can now take one or two arguments (Rich Trott)
    nodejs#12293
* crypto:
  - add sign/verify support for RSASSA-PSS (Tobias Nießen)
    nodejs#11705
* deps:
  - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
    nodejs#16691
  - upgrade libuv to 1.15.0 (cjihrig)
    nodejs#15745
  - upgrade libuv to 1.14.1 (cjihrig)
    nodejs#14866
  - upgrade libuv to 1.13.1 (cjihrig)
    nodejs#14117
  - upgrade libuv to 1.12.0 (cjihrig)
    nodejs#13306
* fs:
  - Add support for fs.write/fs.writeSync(fd, buffer, cb) and
    fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
    (Andreas Lind) nodejs#7856
* inspector:
  - enable --inspect-brk (Refael Ackermann)
    nodejs#12615
* process:
  - add --redirect-warnings command line argument (James M Snell)
    nodejs#10116
* src:
  - allow CLI args in env with NODE_OPTIONS (Sam Roberts)
    nodejs#12028)
  - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
    nodejs#13932
  - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
    nodejs#13172
  - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
    nodejs#12677
* test:
  - remove common.fail() (Rich Trott)
    nodejs#12293

PR-URL: nodejs#16263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment