New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: refactor argument validation for pbkdf2 #15746

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@jasnell
Member

jasnell commented Oct 3, 2017

Move input argument validation to js, using internal/errors.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

@jasnell jasnell requested a review from nodejs/tsc Oct 3, 2017

@lpinca

lpinca approved these changes Oct 3, 2017

Show outdated Hide outdated lib/internal/crypto/pbkdf2.js
Show outdated Hide outdated test/parallel/test-crypto-pbkdf2.js
Show outdated Hide outdated test/parallel/test-crypto-pbkdf2.js
@indutny

indutny approved these changes Oct 3, 2017

LGTM

@thefourtheye

This comment has been minimized.

Show comment
Hide comment
Contributor

thefourtheye commented Oct 5, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
Show outdated Hide outdated doc/api/errors.md

jasnell added some commits Oct 3, 2017

crypto: refactor argument validation for pbkdf2
Move input argument validation to js, using internal/errors.

Also update docs

* `password` and `salt` may be Buffers or any TypedArrays
* `crypto.DEFAULT_ENCODING` changes the returned derivedKey type
@jasnell

This comment has been minimized.

Show comment
Hide comment
Member

jasnell commented Oct 23, 2017

jasnell added a commit that referenced this pull request Oct 23, 2017

crypto: refactor argument validation for pbkdf2
Move input argument validation to js, using internal/errors.

Also update docs

* `password` and `salt` may be Buffers or any TypedArrays
* `crypto.DEFAULT_ENCODING` changes the returned derivedKey type

PR-URL: #15746
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 23, 2017

Member

Landed in 7124b46

Member

jasnell commented Oct 23, 2017

Landed in 7124b46

@jasnell jasnell closed this Oct 23, 2017

addaleax added a commit to ayojs/ayo that referenced this pull request Oct 26, 2017

crypto: refactor argument validation for pbkdf2
Move input argument validation to js, using internal/errors.

Also update docs

* `password` and `salt` may be Buffers or any TypedArrays
* `crypto.DEFAULT_ENCODING` changes the returned derivedKey type

PR-URL: nodejs/node#15746
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017

crypto: refactor argument validation for pbkdf2
Move input argument validation to js, using internal/errors.

Also update docs

* `password` and `salt` may be Buffers or any TypedArrays
* `crypto.DEFAULT_ENCODING` changes the returned derivedKey type

PR-URL: nodejs/node#15746
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment