New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: migrate crypto sign to internal/errors #15757

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@jasnell
Member

jasnell commented Oct 3, 2017

Improve argument type checking and move into js, use internal/errors

Improve tests.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

@lpinca

lpinca approved these changes Oct 5, 2017

Show outdated Hide outdated lib/internal/crypto/sig.js
Show outdated Hide outdated lib/internal/crypto/sig.js
Show outdated Hide outdated lib/internal/crypto/sig.js
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 13, 2017

Member

@nodejs/tsc ... ping? Please review?

Member

jasnell commented Oct 13, 2017

@nodejs/tsc ... ping? Please review?

@jasnell jasnell requested a review from nodejs/tsc Oct 13, 2017

@joyeecheung

LGTM. Next step would be to migrate SignBase::CheckThrow...

@joyeecheung

Checked the wrong box before

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@joyeecheung

joyeecheung Oct 14, 2017

Member

Also after this patch, sign.sign() and verify.verify() take array buffer views as key, the documentation need to be updated (not necessarily in this PR)

Member

joyeecheung commented Oct 14, 2017

Also after this patch, sign.sign() and verify.verify() take array buffer views as key, the documentation need to be updated (not necessarily in this PR)

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 16, 2017

Member

re: SignBase::CheckThrow and the doc updates... yes, I intend to do both in separate PRs.

Member

jasnell commented Oct 16, 2017

re: SignBase::CheckThrow and the doc updates... yes, I intend to do both in separate PRs.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 16, 2017

Member

@nodejs/tsc ... need at least one more TSC signoff on this please

Member

jasnell commented Oct 16, 2017

@nodejs/tsc ... need at least one more TSC signoff on this please

@mcollina

LGTM

@mhdawson

LGTM

@jasnell

This comment has been minimized.

Show comment
Hide comment

jasnell added some commits Oct 3, 2017

crypto: migrate crypto sign to internal/errors
Improve argument type checking and move into js, use internal/errors
@jasnell

This comment has been minimized.

Show comment
Hide comment
Member

jasnell commented Oct 20, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 23, 2017

Member

CI was a bit too red, trying again: https://ci.nodejs.org/job/node-test-commit/13401/

Member

jasnell commented Oct 23, 2017

CI was a bit too red, trying again: https://ci.nodejs.org/job/node-test-commit/13401/

jasnell added a commit that referenced this pull request Oct 24, 2017

crypto: migrate crypto sign to internal/errors
Improve argument type checking and move into js, use internal/errors

PR-URL: #15757
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 24, 2017

Member

Landed in b8bc652

Member

jasnell commented Oct 24, 2017

Landed in b8bc652

@jasnell jasnell closed this Oct 24, 2017

addaleax added a commit to ayojs/ayo that referenced this pull request Oct 26, 2017

crypto: migrate crypto sign to internal/errors
Improve argument type checking and move into js, use internal/errors

PR-URL: nodejs/node#15757
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017

crypto: migrate crypto sign to internal/errors
Improve argument type checking and move into js, use internal/errors

PR-URL: nodejs/node#15757
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment