Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
benchmark,path: remove unused variables #15789
Also, changes to dependencies should be made in those projects' respective upstream repositories instead of node's repository.
The only remaining change is the change to benchmark/fs/read-stream-throughput.js which seems legit also. In that case, the commit message for this PR should be changed to target the benchmark subsystem (when all of the other changes are removed).
I think the commit message should be changed if we're going to keep these two changes together. Perhaps something like "benchmark,path: remove unused variables" because our linter currently does not fail without the changes, so the current message is misleading.
The comment was addressed and seems resolved. PTAL