Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace common.fixturesDir w/ fixtures.path #15819

Conversation

@Druotic
Copy link
Contributor

commented Oct 6, 2017

Description

In test/parallel/test-tls-connect-secure-context.js, replace common.fixturesDir with usage of the common.fixtures module.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

Simple test change for Node Interactive code and learn session.

@mscdex mscdex added the tls label Oct 6, 2017

@Trott Trott added the code-and-learn label Oct 6, 2017

@cjihrig

cjihrig approved these changes Oct 7, 2017

@lpinca

lpinca approved these changes Oct 9, 2017

@lpinca

This comment has been minimized.

@lpinca

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

There is a small typo in commit message: fixutres.path.

@Druotic Druotic force-pushed the Druotic:test-tls-connect-secure-context-common-fixtures branch from 62e38e3 to 3f62305 Oct 9, 2017

@Druotic Druotic changed the title test: replace common.fixturesDir w/ fixutres.path test: replace common.fixturesDir w/ fixtures.path Oct 9, 2017

@Druotic

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2017

Fixed the typo. @lpinca

@jasnell

jasnell approved these changes Oct 9, 2017

@lpinca

This comment has been minimized.

Copy link
Member

commented Oct 10, 2017

Landed in 85a5a2c.

lpinca added a commit that referenced this pull request Oct 10, 2017

test: replace common.fixturesDir w/ fixtures.path
PR-URL: #15819
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

@lpinca lpinca closed this Oct 10, 2017

@Trott

This comment has been minimized.

Copy link
Member

commented Oct 10, 2017

Thanks for the contribution! 🎉

joshualim92 pushed a commit to joshualim92/node that referenced this pull request Oct 10, 2017

test: replace common.fixturesDir w/ fixtures.path
PR-URL: nodejs#15819
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 11, 2017

test: replace common.fixturesDir w/ fixtures.path
PR-URL: #15819
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Oct 11, 2017

Merged

v8.7.0 proposal #15762

addaleax added a commit to addaleax/ayo that referenced this pull request Oct 12, 2017

test: replace common.fixturesDir w/ fixtures.path
PR-URL: nodejs/node#15819
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Nov 14, 2017

test: replace common.fixturesDir w/ fixtures.path
PR-URL: #15819
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Nov 21, 2017

Merged

v6.12.1 proposal #17180

MylesBorins added a commit that referenced this pull request Nov 21, 2017

test: replace common.fixturesDir w/ fixtures.path
PR-URL: #15819
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Nov 28, 2017

test: replace common.fixturesDir w/ fixtures.path
PR-URL: #15819
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.