Join GitHub today
test: improve assert message #15909
First contribution for Node.js Interactive
Affected core subsystem(s)
Hi, @tnguyen14! Welcome and thanks! This change doesn't address the issue that was requested in the Code + Learn task. It still masks that actual values. That is: The message is a string literal that does not provide the contents of the variables that are being compared.
There are two possible ways to address this. One is to remove the message entirely and allow
The other way is to change the string literal to a template string and use
Can you update this to use one of those instead?
Thanks for the quick response @Trott.
I tried both of the solutions you mentioned. When removing the message completely, the default message is not entirely useful. It would show something like
I discussed with @mhdawson briefly, and he suggested that it's best to put in an error message that makes the most sense for developers to debug the issue in the case of failure.
Please let me know if you think it's best to drop the error message entirely.
I'd be +1 on dropping the error message entirely.