Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace string concatenation with template literal #15969

Closed
wants to merge 2 commits into from

Conversation

@chrisbudy
Copy link

chrisbudy commented Oct 6, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@chrisbudy chrisbudy force-pushed the chrisbudy:master branch from a8cbd45 to 7de8956 Oct 6, 2017
@chrisbudy chrisbudy changed the title replace string concatenation with template literal and const order change test: replace string concatenation with template literal Oct 6, 2017
@chrisbudy chrisbudy force-pushed the chrisbudy:master branch from f036b1b to 7de8956 Oct 6, 2017
@mscdex mscdex added the repl label Oct 6, 2017
@Trott Trott added the code-and-learn label Oct 7, 2017
Copy link
Member

BridgeAR left a comment

LGTM but the commit message should be changed while landing. As far as I see it it is not about the string concatenation but instead about using the defaultHistoryPath instead of using path.join later on again with the same input.

@BridgeAR

This comment has been minimized.

@BridgeAR BridgeAR self-assigned this Oct 8, 2017
BridgeAR added a commit to BridgeAR/node that referenced this pull request Oct 8, 2017
PR-URL: nodejs#15969
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Oct 8, 2017

Landed in ab3c84f

Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 !

@BridgeAR BridgeAR closed this Oct 8, 2017
joshualim92 pushed a commit to joshualim92/node that referenced this pull request Oct 10, 2017
PR-URL: nodejs#15969
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins added a commit that referenced this pull request Oct 11, 2017
PR-URL: #15969
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
addaleax added a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
PR-URL: nodejs/node#15969
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.