New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: rename StreamWrap to LibuvStreamWrap #16157

Closed
wants to merge 1 commit into
base: master
from

Conversation

@addaleax
Member

addaleax commented Oct 12, 2017

This should help clarify what kind of resource a StreamWrap represents.

Hopefully one of many PRs to come towards more accessible Node internals.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

src: rename StreamWrap to LibuvStreamWrap
This should help clarify what kind of resource a `StreamWrap`
represents.
@danbev

danbev approved these changes Oct 12, 2017

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 13, 2017

Member

CI failure is unrelated

Member

jasnell commented Oct 13, 2017

CI failure is unrelated

jasnell added a commit that referenced this pull request Oct 13, 2017

src: rename StreamWrap to LibuvStreamWrap
This should help clarify what kind of resource a `StreamWrap`
represents.

PR-URL: #16157
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 13, 2017

Member

Landed in 00fe76d

Member

jasnell commented Oct 13, 2017

Landed in 00fe76d

@jasnell jasnell closed this Oct 13, 2017

@addaleax addaleax deleted the addaleax:stream-wrap-refactor branch Oct 13, 2017

addaleax added a commit to ayojs/ayo that referenced this pull request Oct 15, 2017

src: rename StreamWrap to LibuvStreamWrap
This should help clarify what kind of resource a `StreamWrap`
represents.

PR-URL: nodejs/node#16157
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

targos added a commit that referenced this pull request Oct 18, 2017

src: rename StreamWrap to LibuvStreamWrap
This should help clarify what kind of resource a `StreamWrap`
represents.

PR-URL: #16157
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

targos added a commit that referenced this pull request Oct 18, 2017

src: rename StreamWrap to LibuvStreamWrap
This should help clarify what kind of resource a `StreamWrap`
represents.

PR-URL: #16157
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Nov 16, 2017

Member

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

Member

MylesBorins commented Nov 16, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment