New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build,win: include addons-napi in linter #16181

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@danbev
Member

danbev commented Oct 13, 2017

Currently test/addons-napi files are not being included in the lint
processing. This commit adds them.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build, windows

danbev added some commits Oct 13, 2017

build,win: include addons-napi in linter
Currently test/addons-napi files are not being included in the lint
processing. This commit adds them.
@danbev

This comment has been minimized.

Show comment
Hide comment
Show outdated Hide outdated vcbuild.bat Outdated
@jasnell

This comment has been minimized.

Show comment
Hide comment
Member

jasnell commented Oct 15, 2017

@danbev

This comment has been minimized.

Show comment
Hide comment
@danbev

danbev Oct 16, 2017

Member
test/windows-fanned unstable report looks unrelated

console output:

Checking ^not ok
c:\workspace\node-test-binary-windows\test.tap:
not ok 468 inspector/test-bindings # TODO : Fix flaky test
not ok 469 inspector/test-debug-end # TODO : Fix flaky test
Build step 'Jenkins Text Finder' changed build result to UNSTABLE
Notifying upstream projects of job completion
Finished: UNSTABLE
Member

danbev commented Oct 16, 2017

test/windows-fanned unstable report looks unrelated

console output:

Checking ^not ok
c:\workspace\node-test-binary-windows\test.tap:
not ok 468 inspector/test-bindings # TODO : Fix flaky test
not ok 469 inspector/test-debug-end # TODO : Fix flaky test
Build step 'Jenkins Text Finder' changed build result to UNSTABLE
Notifying upstream projects of job completion
Finished: UNSTABLE

danbev added a commit to danbev/node that referenced this pull request Oct 16, 2017

build,win: include addons-napi in linter
Currently test/addons-napi files are not being included in the lint
processing. This commit adds them.

PR-URL: nodejs#16181
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danbev

This comment has been minimized.

Show comment
Hide comment
@danbev

danbev Oct 16, 2017

Member

Landed in 7832e69

Member

danbev commented Oct 16, 2017

Landed in 7832e69

@danbev danbev closed this Oct 16, 2017

@danbev danbev deleted the danbev:win-napi-linter branch Oct 16, 2017

targos added a commit that referenced this pull request Oct 18, 2017

build,win: include addons-napi in linter
Currently test/addons-napi files are not being included in the lint
processing. This commit adds them.

PR-URL: #16181
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

targos added a commit that referenced this pull request Oct 18, 2017

build,win: include addons-napi in linter
Currently test/addons-napi files are not being included in the lint
processing. This commit adds them.

PR-URL: #16181
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Oct 18, 2017

build,win: include addons-napi in linter
Currently test/addons-napi files are not being included in the lint
processing. This commit adds them.

PR-URL: nodejs/node#16181
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment