New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n-api: use module name macro #16185

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@mhdawson
Member

mhdawson commented Oct 13, 2017

Update tests to use module name macro

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

n-api, test

n-api: use module name macro
Update tests to use module name macro
@gabrielschulhof

@mhdawson there are a few more:

$ git grep -nEH '^(NAPI|NODE)_MODULE' -- test | \
  grep -vE 'BUILTIN|NODE_GYP_MODULE_NAME|INTERNAL' | \
  awk -F ':' '{ print $1; }' | \
  sort -u
test/addons/callback-scope/binding.cc
test/addons/dlopen-ping-pong/binding.cc
test/addons-napi/test_warning/test_warning2.c
test/addons-napi/test_warning/test_warning.c
test/addons/node-module-version/binding.cc
test/addons/openssl-binding/binding.cc
test/addons/zlib-binding/binding.cc
test/gc/binding.cc

Might as well catch 'em all, eh?

@mhdawson

This comment has been minimized.

Member

mhdawson commented Oct 13, 2017

sure, I guess I used the wrong search. Updating now.

@mhdawson

This comment has been minimized.

Member

mhdawson commented Oct 13, 2017

Ah I see they are not in the n-api set thats why I did not see them. Anyway fixing them up

@mhdawson

This comment has been minimized.

Member

mhdawson commented Oct 13, 2017

@gabrielschulhof pushed commit to update the rest of them

@jasnell

This comment has been minimized.

jasnell added a commit that referenced this pull request Oct 15, 2017

n-api: use module name macro
Update tests to use module name macro

PR-URL: #16185
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell

This comment has been minimized.

Member

jasnell commented Oct 15, 2017

Landed in 6bc82da

@jasnell jasnell closed this Oct 15, 2017

targos added a commit that referenced this pull request Oct 18, 2017

n-api: use module name macro
Update tests to use module name macro

PR-URL: #16185
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

targos added a commit that referenced this pull request Oct 18, 2017

n-api: use module name macro
Update tests to use module name macro

PR-URL: #16185
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Oct 18, 2017

n-api: use module name macro
Update tests to use module name macro

PR-URL: nodejs/node#16185
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 15, 2018

n-api: use module name macro
Update tests to use module name macro

This applies parts of 6bc82da that are
relevant to N-API.

PR-URL: nodejs#16185
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 3, 2018

n-api: use module name macro
Update tests to use module name macro

PR-URL: nodejs#16185
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 6, 2018

n-api: use module name macro
Update tests to use module name macro

PR-URL: nodejs#16185
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018

n-api: use module name macro
Update tests to use module name macro

PR-URL: nodejs#16185
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 15, 2018

n-api: use module name macro
Update tests to use module name macro

PR-URL: nodejs#16185
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 15, 2018

n-api: use module name macro
Update tests to use module name macro

PR-URL: nodejs#16185
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018

n-api: use module name macro
Update tests to use module name macro

PR-URL: nodejs#16185
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018

n-api: use module name macro
Update tests to use module name macro

PR-URL: nodejs#16185
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018

n-api: use module name macro
Update tests to use module name macro

PR-URL: nodejs#16185
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Apr 16, 2018

n-api: use module name macro
Update tests to use module name macro

Backport-PR-URL: #19447
PR-URL: #16185
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Apr 16, 2018

Merged

v6.14.2 proposal #19996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment