New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add UV_THREADPOOL_SIZE link definition #16193

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@maclover7
Member

maclover7 commented Oct 13, 2017

Currently is rendered as "see the [UV_THREADPOOL_SIZE][] documentation",

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

doc: add UV_THREADPOOL_SIZE link definition
Currently is rendered as "see the [UV_THREADPOOL_SIZE][] documentation",
since there was no link definition in the file.
@joyeecheung

I don't think this needs 48 hours to land

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@joyeecheung

joyeecheung Oct 14, 2017

Member

Landed in 0ff0c70, thanks!

Member

joyeecheung commented Oct 14, 2017

Landed in 0ff0c70, thanks!

joyeecheung added a commit that referenced this pull request Oct 14, 2017

doc: add UV_THREADPOOL_SIZE link definition
Currently is rendered as "see the [UV_THREADPOOL_SIZE][]
documentation", since there was no link definition in the file.

PR-URL: #16193
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@maclover7 maclover7 deleted the maclover7:jm-uvtp-doc branch Oct 14, 2017

addaleax added a commit to ayojs/ayo that referenced this pull request Oct 15, 2017

doc: add UV_THREADPOOL_SIZE link definition
Currently is rendered as "see the [UV_THREADPOOL_SIZE][]
documentation", since there was no link definition in the file.

PR-URL: nodejs/node#16193
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

targos added a commit that referenced this pull request Oct 18, 2017

doc: add UV_THREADPOOL_SIZE link definition
Currently is rendered as "see the [UV_THREADPOOL_SIZE][]
documentation", since there was no link definition in the file.

PR-URL: #16193
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

targos added a commit that referenced this pull request Oct 18, 2017

doc: add UV_THREADPOOL_SIZE link definition
Currently is rendered as "see the [UV_THREADPOOL_SIZE][]
documentation", since there was no link definition in the file.

PR-URL: #16193
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment