New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: check uv_prepare_stop return value #16268

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@addaleax
Member

addaleax commented Oct 17, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src/http2

CI: https://ci.nodejs.org/job/node-test-commit/13235/

@bnoordhuis

LGTM. uv_prepare_stop() is infallible though, practically speaking, but the extra check won't hurt.

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Oct 19, 2017

Member

Landed in bf1bace

Member

addaleax commented Oct 19, 2017

Landed in bf1bace

@addaleax addaleax closed this Oct 19, 2017

@addaleax addaleax deleted the addaleax:http2-prep-stop-check branch Oct 19, 2017

addaleax added a commit that referenced this pull request Oct 19, 2017

src: check uv_prepare_stop return value
PR-URL: #16268
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Oct 23, 2017

src: check uv_prepare_stop return value
PR-URL: #16268
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Oct 26, 2017

src: check uv_prepare_stop return value
PR-URL: nodejs/node#16268
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017

src: check uv_prepare_stop return value
PR-URL: nodejs/node#16268
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment