New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add recommendations for first timers #16350

Merged
merged 1 commit into from Oct 24, 2017

Conversation

@refack
Member

refack commented Oct 20, 2017

Checklist
Affected core subsystem(s)

doc,meta

Show outdated Hide outdated COLLABORATOR_GUIDE.md Outdated
Show outdated Hide outdated COLLABORATOR_GUIDE.md Outdated
Show outdated Hide outdated COLLABORATOR_GUIDE.md Outdated
Show outdated Hide outdated COLLABORATOR_GUIDE.md Outdated
@Trott

Trott approved these changes Oct 22, 2017

LGTM modulo spelling nits.

Show outdated Hide outdated COLLABORATOR_GUIDE.md Outdated
@@ -24,8 +24,9 @@ understand the project governance model as outlined in
## Issues and Pull Requests
Courtesy should always be shown to individuals submitting issues and
pull requests to the Node.js project.
Courtesy should **always** be shown to individuals submitting issues and pull

This comment has been minimized.

@refack

refack Oct 23, 2017

Member

Not an objection, but just a comment that I try to be very sparing with bold, italics, etc. It gets out of hand pretty easily.

Ack. I felt this is a point worth emphasising both to Collaborators, and to contributors who read this (as on most screens it appears above the fold)

@refack

refack Oct 23, 2017

Member

Not an objection, but just a comment that I try to be very sparing with bold, italics, etc. It gets out of hand pretty easily.

Ack. I felt this is a point worth emphasising both to Collaborators, and to contributors who read this (as on most screens it appears above the fold)

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Oct 23, 2017

Member

Addressed comment PTAL

Member

refack commented Oct 23, 2017

Addressed comment PTAL

refack added a commit to refack/node that referenced this pull request Oct 24, 2017

doc: add recommendations for first timers
PR-URL: nodejs#16350
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
doc: add recommendations for first timers
PR-URL: #16350
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

@refack refack merged commit 7671f25 into nodejs:master Oct 24, 2017

@refack refack deleted the refack:collab-guide-tweaks branch Oct 24, 2017

cjihrig added a commit that referenced this pull request Oct 25, 2017

doc: add recommendations for first timers
PR-URL: #16350
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

@cjihrig cjihrig referenced this pull request Oct 25, 2017

Merged

v8.8.1 proposal #16498

addaleax added a commit to ayojs/ayo that referenced this pull request Oct 26, 2017

doc: add recommendations for first timers
PR-URL: nodejs/node#16350
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

MylesBorins added a commit that referenced this pull request Nov 16, 2017

doc: add recommendations for first timers
PR-URL: #16350
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

@MylesBorins MylesBorins referenced this pull request Nov 21, 2017

Merged

v6.12.1 proposal #17180

MylesBorins added a commit that referenced this pull request Nov 21, 2017

doc: add recommendations for first timers
PR-URL: #16350
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

MylesBorins added a commit that referenced this pull request Nov 28, 2017

doc: add recommendations for first timers
PR-URL: #16350
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017

doc: add recommendations for first timers
PR-URL: nodejs/node#16350
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment