New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer: convert `buffer.transcode` to use internal/errors #16352

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@starkwang
Contributor

starkwang commented Oct 21, 2017

buffer.transcode is still using raw TypeError. This change is to convert it to use internal/errors.

Ref: #11273

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

buffer

@targos

targos approved these changes Oct 21, 2017

Show outdated Hide outdated lib/buffer.js Outdated
@lpinca

lpinca approved these changes Oct 21, 2017

@jasnell

LGTM with the buffer and uint8array changed to Buffer and Uint8Array

buffer: convert buffer.transcode to use internal/errors
`buffer.transcode` is still using raw TypeError. This change is to
convert it to use internal/errors.

Ref: #11273
@starkwang

This comment has been minimized.

Show comment
Hide comment
@starkwang

starkwang Oct 22, 2017

Contributor

Pushed commit to address comment.

Contributor

starkwang commented Oct 22, 2017

Pushed commit to address comment.

@joyeecheung

This comment has been minimized.

Show comment
Hide comment

@joyeecheung joyeecheung added the errors label Oct 23, 2017

gireeshpunathil added a commit that referenced this pull request Oct 23, 2017

buffer: buffer.transcode to use internal/errors
`buffer.transcode` is still using raw TypeError. This change is to
convert it to use internal/errors.

Ref: #11273
PR-URL: #16352
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@gireeshpunathil

This comment has been minimized.

Show comment
Hide comment
@gireeshpunathil

gireeshpunathil Oct 23, 2017

Member

Landed in e79a61c , thanks for the contribution!

Member

gireeshpunathil commented Oct 23, 2017

Landed in e79a61c , thanks for the contribution!

@targos

This comment has been minimized.

Show comment
Hide comment
@targos

targos Oct 23, 2017

Member

I added the semver-major label

Member

targos commented Oct 23, 2017

I added the semver-major label

addaleax added a commit to ayojs/ayo that referenced this pull request Oct 26, 2017

buffer: buffer.transcode to use internal/errors
`buffer.transcode` is still using raw TypeError. This change is to
convert it to use internal/errors.

Ref: nodejs/node#11273
PR-URL: nodejs/node#16352
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017

buffer: buffer.transcode to use internal/errors
`buffer.transcode` is still using raw TypeError. This change is to
convert it to use internal/errors.

Ref: nodejs/node#11273
PR-URL: nodejs/node#16352
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment