Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: migrate setEngine to internal/errors #16429

Closed

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Oct 24, 2017

Migrate setEngine to use internal/errors, tho it's not entirely clear what conditions are required to trigger it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

@lpinca
lpinca approved these changes Oct 24, 2017
@jasnell
Copy link
Member Author

@jasnell jasnell commented Oct 24, 2017

@targos
targos approved these changes Oct 24, 2017
@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Oct 25, 2017

CI failures should be unrelated

jasnell added a commit that referenced this pull request Oct 25, 2017
PR-URL: #16429
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@jasnell
Copy link
Member Author

@jasnell jasnell commented Oct 25, 2017

Landed in a78327f

@jasnell jasnell closed this Oct 25, 2017
addaleax added a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
PR-URL: nodejs/node#16429
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
PR-URL: nodejs/node#16429
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.