New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: migrate setEngine to internal/errors #16429

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@jasnell
Member

jasnell commented Oct 24, 2017

Migrate setEngine to use internal/errors, tho it's not entirely clear what conditions are required to trigger it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

@lpinca

lpinca approved these changes Oct 24, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell
Member

jasnell commented Oct 24, 2017

@targos

targos approved these changes Oct 24, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@joyeecheung

joyeecheung Oct 25, 2017

Member

CI failures should be unrelated

Member

joyeecheung commented Oct 25, 2017

CI failures should be unrelated

jasnell added a commit that referenced this pull request Oct 25, 2017

crypto: migrate setEngine to internal/errors
PR-URL: #16429
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 25, 2017

Member

Landed in a78327f

Member

jasnell commented Oct 25, 2017

Landed in a78327f

@jasnell jasnell closed this Oct 25, 2017

addaleax added a commit to ayojs/ayo that referenced this pull request Oct 26, 2017

crypto: migrate setEngine to internal/errors
PR-URL: nodejs/node#16429
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017

crypto: migrate setEngine to internal/errors
PR-URL: nodejs/node#16429
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment