Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: migrate timingSafeEqual to internal/errors #16448

Closed

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Oct 24, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

@jasnell
Copy link
Member Author

@jasnell jasnell commented Oct 25, 2017

@targos
targos approved these changes Oct 25, 2017
@jasnell
Copy link
Member Author

@jasnell jasnell commented Oct 25, 2017

Attempting partial test again on arm: https://ci.nodejs.org/job/node-test-binary-arm/11217/

@jasnell
Copy link
Member Author

@jasnell jasnell commented Oct 25, 2017

CI looks good

@jasnell jasnell added this to In Progress in Error Codes Oct 25, 2017
jasnell added a commit that referenced this pull request Oct 26, 2017
PR-URL: #16448
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@jasnell
Copy link
Member Author

@jasnell jasnell commented Oct 26, 2017

Landed in eeada6c with a minor nit fixed while landing

@jasnell jasnell closed this Oct 26, 2017
@jasnell jasnell moved this from In Progress to Done in Error Codes Oct 26, 2017
addaleax added a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
PR-URL: nodejs/node#16448
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
PR-URL: nodejs/node#16448
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Error Codes
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.