New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: use CHECK instead in getSSLCiphers #16453

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
5 participants
@jasnell
Member

jasnell commented Oct 24, 2017

The previous throws should never happen, and if they do, they signal a larger issue in core. Make these checks rather than throws

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

Show outdated Hide outdated src/node_crypto.cc Outdated
Show outdated Hide outdated src/node_crypto.cc Outdated
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 25, 2017

Member

CI failures are unrelated.

Member

jasnell commented Oct 25, 2017

CI failures are unrelated.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell
Member

jasnell commented Oct 25, 2017

@jasnell jasnell added this to In Progress in Error Codes Oct 25, 2017

@mcollina

LGTM

crypto: use CHECK instead in getSSLCiphers
The previous throws should never happen, and if they do, they
signal a larger issue in core. Make these checks rather than
throws.
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 26, 2017

Member

@bnoordhuis ... updated to remove the errant change. PTAL

Member

jasnell commented Oct 26, 2017

@bnoordhuis ... updated to remove the errant change. PTAL

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell
Member

jasnell commented Oct 26, 2017

jasnell added a commit that referenced this pull request Oct 26, 2017

crypto: use CHECK instead in getSSLCiphers
The previous throws should never happen, and if they do, they
signal a larger issue in core. Make these checks rather than
throws.

PR-URL: #16453
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 26, 2017

Member

Landed in df8c6c3

Member

jasnell commented Oct 26, 2017

Landed in df8c6c3

@jasnell jasnell closed this Oct 26, 2017

addaleax added a commit to ayojs/ayo that referenced this pull request Oct 26, 2017

crypto: use CHECK instead in getSSLCiphers
The previous throws should never happen, and if they do, they
signal a larger issue in core. Make these checks rather than
throws.

PR-URL: nodejs/node#16453
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

@targos targos moved this from In Progress to Done in Error Codes Oct 29, 2017

addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017

crypto: use CHECK instead in getSSLCiphers
The previous throws should never happen, and if they do, they
signal a larger issue in core. Make these checks rather than
throws.

PR-URL: nodejs/node#16453
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment