New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: migrate crypto.randomBytes to internal/errors #16454

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
6 participants
@jasnell
Member

jasnell commented Oct 24, 2017

Previously had migrated randomBytesFill, this gives the same treatment to crypto.randomBytes()

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

@targos

targos approved these changes Oct 24, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell
Member

jasnell commented Oct 25, 2017

@lpinca

lpinca approved these changes Oct 25, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 25, 2017

Member

CI failures are unrelated

Member

jasnell commented Oct 25, 2017

CI failures are unrelated

@jasnell jasnell added this to In Progress in Error Codes Oct 25, 2017

@jasnell jasnell moved this from In Progress to Done in Error Codes Oct 26, 2017

jasnell added a commit that referenced this pull request Oct 26, 2017

crypto: migrate crypto.randomBytes to internal/errors
PR-URL: #16454
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 26, 2017

Member

Landed in 0a03e35

Member

jasnell commented Oct 26, 2017

Landed in 0a03e35

@jasnell jasnell closed this Oct 26, 2017

addaleax added a commit to ayojs/ayo that referenced this pull request Oct 26, 2017

crypto: migrate crypto.randomBytes to internal/errors
PR-URL: nodejs/node#16454
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017

crypto: migrate crypto.randomBytes to internal/errors
PR-URL: nodejs/node#16454
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@tniessen tniessen referenced this pull request Dec 10, 2017

Closed

doc: note that randomBytes throws when passed null #17594

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment