New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove loader hooks from unsupported features #16465

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@teppeis
Contributor

teppeis commented Oct 24, 2017

It's implemented in #15445.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 25, 2017

Member

this should not need to wait 48 hours to land

Member

jasnell commented Oct 25, 2017

this should not need to wait 48 hours to land

jasnell added a commit that referenced this pull request Oct 25, 2017

doc: remove loader hooks from unsupported features
PR-URL: #16465
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 25, 2017

Member

Landed in d2e44d5

Member

jasnell commented Oct 25, 2017

Landed in d2e44d5

@jasnell jasnell closed this Oct 25, 2017

cjihrig added a commit that referenced this pull request Oct 25, 2017

doc: remove loader hooks from unsupported features
PR-URL: #16465
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@cjihrig cjihrig referenced this pull request Oct 25, 2017

Merged

v8.8.1 proposal #16498

@teppeis teppeis deleted the teppeis:patch-1 branch Oct 26, 2017

addaleax added a commit to ayojs/ayo that referenced this pull request Oct 26, 2017

doc: remove loader hooks from unsupported features
PR-URL: nodejs/node#16465
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017

doc: remove loader hooks from unsupported features
PR-URL: nodejs/node#16465
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment