New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: migrate setFlagsFromString to internal/errors #16535

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@jasnell
Member

jasnell commented Oct 26, 2017

Simple type checking and quick doc clean up to sync with the code

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

v8

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell
Member

jasnell commented Oct 26, 2017

@refack

refack approved these changes Oct 27, 2017

FWIW

@targos

targos approved these changes Oct 27, 2017

@mcollina

LGTM

@lpinca

lpinca approved these changes Oct 27, 2017

@jasnell

This comment has been minimized.

Show comment
Hide comment

jasnell added a commit that referenced this pull request Oct 30, 2017

v8: migrate setFlagsFromString to internal/errors
PR-URL: #16535
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 30, 2017

Member

Landed in 64168eb

Member

jasnell commented Oct 30, 2017

Landed in 64168eb

@jasnell jasnell closed this Oct 30, 2017

jasnell added a commit that referenced this pull request Oct 30, 2017

v8: migrate setFlagsFromString to internal/errors
PR-URL: #16535
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Qard added a commit to ayojs/ayo that referenced this pull request Nov 2, 2017

v8: migrate setFlagsFromString to internal/errors
PR-URL: nodejs/node#16535
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017

v8: migrate setFlagsFromString to internal/errors
PR-URL: nodejs/node#16535
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment