New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib: finish migrating to internal/errors #16540

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@jasnell
Member

jasnell commented Oct 27, 2017

Finish migrating the zlib binding over to use internal/errors

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

zlib, errors

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell
Member

jasnell commented Oct 27, 2017

@refack

refack approved these changes Oct 27, 2017

FWIW

@joyeecheung

LGTM with a question?

write_js_callback, dictionary, dictionary_len);
bool ret = Init(ctx, level, windowBits, memLevel, strategy, write_result,
write_js_callback, dictionary, dictionary_len);
if (!ret) goto end;

This comment has been minimized.

@joyeecheung

joyeecheung Oct 27, 2017

Member

Any reason we need a goto here? (other than one less line of duplicate code?)

@joyeecheung

joyeecheung Oct 27, 2017

Member

Any reason we need a goto here? (other than one less line of duplicate code?)

This comment has been minimized.

@jasnell

jasnell Oct 27, 2017

Member

just that... didn't want to duplicate the line of code

@jasnell

jasnell Oct 27, 2017

Member

just that... didn't want to duplicate the line of code

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@mcollina

LGTM

@lpinca

lpinca approved these changes Oct 27, 2017

common.expectsError(
() => zlib.createDeflateRaw({ windowBits: 8 }),
{
code: 'ERR_ZLIB_INITIALIZATION_FAILED',

This comment has been minimized.

@lpinca

lpinca Oct 27, 2017

Member

We need a new way to test this error once #16511 is merged.

@lpinca

lpinca Oct 27, 2017

Member

We need a new way to test this error once #16511 is merged.

jasnell added a commit that referenced this pull request Oct 29, 2017

zlib: finish migrating to internal/errors
PR-URL: #16540
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 29, 2017

Member

Landed in 896eaf6

Member

jasnell commented Oct 29, 2017

Landed in 896eaf6

@jasnell jasnell closed this Oct 29, 2017

Qard added a commit to ayojs/ayo that referenced this pull request Nov 2, 2017

zlib: finish migrating to internal/errors
PR-URL: nodejs/node#16540
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Qard added a commit to ayojs/ayo that referenced this pull request Nov 2, 2017

zlib: finish migrating to internal/errors
PR-URL: nodejs/node#16540
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017

zlib: finish migrating to internal/errors
PR-URL: nodejs/node#16540
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment