New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update AUTHORS list #16571

Merged
merged 1 commit into from Nov 21, 2017

Conversation

Projects
None yet
6 participants
@targos
Member

targos commented Oct 28, 2017

Checklist

For people who have their GitHub handle as name, I picked their real name from the GitHub profile (if present). Should we ping them to ask if that's fine?

@@ -278,13 +321,17 @@ Tarun Batra <tarun.batra00@gmail.com> Tarun <tarun.batra00@gmail.com>
Ted Young <ted@radicaldesigns.org>
Thomas Lee <thomas.lee@shinetech.com> <tom@tom-debian.sensis.com.au>
Thomas Reggi <thomas@reggi.com>
Tierney Cyren <hello@bnb.im> &! (bitandbang) <tieliaco@gmail.com>
Tierney Cyren <hello@bnb.im> bitandbang <hello@bnb.im>

This comment has been minimized.

@targos

targos Oct 28, 2017

Member

@bnb is this correct? The first email address is linked to another account (TierneyC)

@targos

targos Oct 28, 2017

Member

@bnb is this correct? The first email address is linked to another account (TierneyC)

@lpinca

lpinca approved these changes Oct 28, 2017

Ali Groening <ali.groening@gmail.com>
Mike Fleming <flemingatx@gmail.com>
WeiPlanet <xwjiang@gmail.com>
243083df <243083df@dispostable.com>

This comment has been minimized.

@lpinca

lpinca Oct 28, 2017

Member

Hmm this account can be stolen via the publicly visible disposable email address.

@lpinca

lpinca Oct 28, 2017

Member

Hmm this account can be stolen via the publicly visible disposable email address.

This comment has been minimized.

@targos

targos Oct 28, 2017

Member

what can we do?

@targos

targos Oct 28, 2017

Member

what can we do?

This comment has been minimized.

@lpinca

lpinca Oct 28, 2017

Member

Not sure, remove? edit?

@lpinca

lpinca Oct 28, 2017

Member

Not sure, remove? edit?

This comment has been minimized.

@targos

targos Oct 29, 2017

Member

I if just remove it, it will appear again next time.
I can add it to .mailmap as "Anonymous".

@targos

targos Oct 29, 2017

Member

I if just remove it, it will appear again next time.
I can add it to .mailmap as "Anonymous".

@targos

This comment has been minimized.

Show comment
Hide comment
@targos

targos Nov 13, 2017

Member

I just rebased and ran the script again, PTAL

Member

targos commented Nov 13, 2017

I just rebased and ran the script again, PTAL

@targos

This comment has been minimized.

Show comment
Hide comment
@targos

targos Nov 18, 2017

Member

Updated again.

Ping anyone: please review ;)

Member

targos commented Nov 18, 2017

Updated again.

Ping anyone: please review ;)

doc: update AUTHORS list
PR-URL: #16571
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@targos targos merged commit 334a7aa into nodejs:master Nov 21, 2017

@targos targos deleted the targos:update-authors branch Nov 21, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: update AUTHORS list
PR-URL: #16571
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

MylesBorins added a commit that referenced this pull request Dec 19, 2017

doc: update AUTHORS list
PR-URL: #16571
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn added a commit that referenced this pull request Dec 19, 2017

doc: update AUTHORS list
PR-URL: #16571
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: update AUTHORS list
PR-URL: #16571
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

doc: update AUTHORS list
PR-URL: nodejs#16571
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment