Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: complete migration to internal/errors #16589

Closed
wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

stream

@mcollina mcollina requested review from jasnell, BridgeAR and a team October 29, 2017 15:39
@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. stream Issues and PRs related to the stream subsystem. labels Oct 29, 2017
@mcollina
Copy link
Member Author

@nodejs/tsc this needs expedite, as we need it for the 9 release. I'm sorry, but I caught these just now.

@mcollina
Copy link
Member Author

@addaleax
Copy link
Member

I think @jasnell wanted to build the binaries ~ now? I’m okay with expediting but maybe we have the time for a CITGM run as well?

@mcollina mcollina added the semver-major PRs that contain breaking changes and should be released in the next major version. label Oct 29, 2017
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One bit but generally lgtm and +1 on fast tracking

@@ -284,7 +284,7 @@ function chunkInvalid(state, chunk) {
typeof chunk !== 'string' &&
chunk !== undefined &&
!state.objectMode) {
er = new TypeError('Invalid non-string/buffer chunk');
er = new errors.TypeError('ERR_STREAM_INVALID_CHUNK');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably just use ERR_INVALID_ARG_TYPE here

} else if (typeof chunk !== 'string' &&
chunk !== undefined &&
!state.objectMode) {
er = new TypeError('Invalid non-string/buffer chunk');
er = new errors.TypeError('ERR_STREAM_INVALID_CHUNK');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

@mcollina
Copy link
Member Author

<a id="ERR_STREAM_CANNOT_PIPE"></a>
### ERR_STREAM_CANNOT_PIPE

Used when an attempt is made to call [`stream.pipe()`][] on a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing link definitions, so are Writable and stream.write()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.
@mcollina
Copy link
Member Author

@mcollina
Copy link
Member Author

@jasnell
Copy link
Member

jasnell commented Oct 29, 2017

I'll be doing one final pull from master this afternoon and will be kicking off the release build later on today.

@mcollina
Copy link
Member Author

Landed as 6e86a66

@mcollina mcollina closed this Oct 29, 2017
@mcollina mcollina deleted the stream-new-errors branch October 29, 2017 18:08
mcollina added a commit that referenced this pull request Oct 29, 2017
Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.

PR-URL: #16589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@maclover7 maclover7 mentioned this pull request Oct 29, 2017
2 tasks
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.

PR-URL: nodejs/node#16589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.

PR-URL: nodejs/node#16589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.

PR-URL: nodejs/node#16589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@kjin kjin mentioned this pull request May 1, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. semver-major PRs that contain breaking changes and should be released in the next major version. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants