New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: complete migration to internal/errors #16589

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@mcollina
Member

mcollina commented Oct 29, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

stream

@mcollina mcollina requested review from jasnell, BridgeAR and nodejs/tsc Oct 29, 2017

@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina

mcollina Oct 29, 2017

Member

@nodejs/tsc this needs expedite, as we need it for the 9 release. I'm sorry, but I caught these just now.

Member

mcollina commented Oct 29, 2017

@nodejs/tsc this needs expedite, as we need it for the 9 release. I'm sorry, but I caught these just now.

@mcollina

This comment has been minimized.

Show comment
Hide comment
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Oct 29, 2017

Member

I think @jasnell wanted to build the binaries ~ now? I’m okay with expediting but maybe we have the time for a CITGM run as well?

Member

addaleax commented Oct 29, 2017

I think @jasnell wanted to build the binaries ~ now? I’m okay with expediting but maybe we have the time for a CITGM run as well?

@jasnell

One bit but generally lgtm and +1 on fast tracking

Show outdated Hide outdated lib/_stream_readable.js Outdated
Show outdated Hide outdated lib/_stream_writable.js Outdated
@mcollina

This comment has been minimized.

Show comment
Hide comment
<a id="ERR_STREAM_CANNOT_PIPE"></a>
### ERR_STREAM_CANNOT_PIPE
Used when an attempt is made to call [`stream.pipe()`][] on a

This comment has been minimized.

@joyeecheung

joyeecheung Oct 29, 2017

Member

Missing link definitions, so are Writable and stream.write()

@joyeecheung

joyeecheung Oct 29, 2017

Member

Missing link definitions, so are Writable and stream.write()

This comment has been minimized.

@mcollina

mcollina Oct 29, 2017

Member

added

@mcollina

mcollina Oct 29, 2017

Member

added

stream: complete migration to internal/errors
Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.
@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina

This comment has been minimized.

Show comment
Hide comment
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Oct 29, 2017

Member

I'll be doing one final pull from master this afternoon and will be kicking off the release build later on today.

Member

jasnell commented Oct 29, 2017

I'll be doing one final pull from master this afternoon and will be kicking off the release build later on today.

@mcollina

This comment has been minimized.

Show comment
Hide comment
@mcollina

mcollina Oct 29, 2017

Member

Landed as 6e86a66

Member

mcollina commented Oct 29, 2017

Landed as 6e86a66

@mcollina mcollina closed this Oct 29, 2017

@mcollina mcollina deleted the mcollina:stream-new-errors branch Oct 29, 2017

mcollina added a commit that referenced this pull request Oct 29, 2017

stream: complete migration to internal/errors
Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.

PR-URL: #16589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@maclover7 maclover7 referenced this pull request Oct 29, 2017

Closed

doc: add link for stream.pipe() #16593

2 of 2 tasks complete

Qard added a commit to ayojs/ayo that referenced this pull request Nov 2, 2017

stream: complete migration to internal/errors
Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.

PR-URL: nodejs/node#16589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Qard added a commit to ayojs/ayo that referenced this pull request Nov 2, 2017

stream: complete migration to internal/errors
Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.

PR-URL: nodejs/node#16589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017

stream: complete migration to internal/errors
Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.

PR-URL: nodejs/node#16589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

@kjin kjin referenced this pull request May 1, 2018

Closed

[8.x] Backport http2 changes from 9.x #20456

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment