Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: complete migration to internal/errors #16589

Closed
wants to merge 1 commit into from

Conversation

@mcollina
Copy link
Member

@mcollina mcollina commented Oct 29, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

stream

@mcollina mcollina requested review from jasnell, BridgeAR and nodejs/tsc Oct 29, 2017
@mcollina
Copy link
Member Author

@mcollina mcollina commented Oct 29, 2017

@nodejs/tsc this needs expedite, as we need it for the 9 release. I'm sorry, but I caught these just now.

@addaleax
Copy link
Member

@addaleax addaleax commented Oct 29, 2017

I think @jasnell wanted to build the binaries ~ now? I’m okay with expediting but maybe we have the time for a CITGM run as well?

Copy link
Member

@jasnell jasnell left a comment

One bit but generally lgtm and +1 on fast tracking

lib/_stream_readable.js Outdated
@@ -284,7 +284,7 @@ function chunkInvalid(state, chunk) {
typeof chunk !== 'string' &&
chunk !== undefined &&
!state.objectMode) {
er = new TypeError('Invalid non-string/buffer chunk');
er = new errors.TypeError('ERR_STREAM_INVALID_CHUNK');

This comment has been minimized.

@jasnell

jasnell Oct 29, 2017
Member

Should probably just use ERR_INVALID_ARG_TYPE here

lib/_stream_writable.js Outdated
} else if (typeof chunk !== 'string' &&
chunk !== undefined &&
!state.objectMode) {
er = new TypeError('Invalid non-string/buffer chunk');
er = new errors.TypeError('ERR_STREAM_INVALID_CHUNK');

This comment has been minimized.

@jasnell

jasnell Oct 29, 2017
Member

And here

<a id="ERR_STREAM_CANNOT_PIPE"></a>
### ERR_STREAM_CANNOT_PIPE

Used when an attempt is made to call [`stream.pipe()`][] on a

This comment has been minimized.

@joyeecheung

joyeecheung Oct 29, 2017
Member

Missing link definitions, so are Writable and stream.write()

This comment has been minimized.

@mcollina

mcollina Oct 29, 2017
Author Member

added

Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.
@mcollina mcollina force-pushed the mcollina:stream-new-errors branch to 2651f29 Oct 29, 2017
@jasnell
Copy link
Member

@jasnell jasnell commented Oct 29, 2017

I'll be doing one final pull from master this afternoon and will be kicking off the release build later on today.

@mcollina
Copy link
Member Author

@mcollina mcollina commented Oct 29, 2017

Landed as 6e86a66

@mcollina mcollina closed this Oct 29, 2017
@mcollina mcollina deleted the mcollina:stream-new-errors branch Oct 29, 2017
mcollina added a commit that referenced this pull request Oct 29, 2017
Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.

PR-URL: #16589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@maclover7 maclover7 mentioned this pull request Oct 29, 2017
2 of 2 tasks complete
Qard added a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.

PR-URL: nodejs/node#16589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Qard added a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.

PR-URL: nodejs/node#16589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.

PR-URL: nodejs/node#16589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@kjin kjin mentioned this pull request May 1, 2018
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.