New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fail tests if malformed status file #16703

Closed
wants to merge 1 commit into
base: master
from

Conversation

@Trott
Member

Trott commented Nov 3, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools test

@gireeshpunathil

This comment has been minimized.

Show comment
Hide comment
@gireeshpunathil

gireeshpunathil Nov 3, 2017

Member

@Trott - will this check be performed in the beginning for all the folders before any test starts, or before the commencement of tests after entering the respective folders? I guess the former is preferred?

Member

gireeshpunathil commented Nov 3, 2017

@Trott - will this check be performed in the beginning for all the folders before any test starts, or before the commencement of tests after entering the respective folders? I guess the former is preferred?

Show outdated Hide outdated tools/test.py Outdated
@cjihrig

cjihrig approved these changes Nov 3, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Nov 3, 2017

Member

will this check be performed in the beginning for all the folders before any test starts,

@gireeshpunathil Yes.

Member

Trott commented Nov 3, 2017

will this check be performed in the beginning for all the folders before any test starts,

@gireeshpunathil Yes.

@Trott

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell approved these changes Nov 3, 2017

@refack

refack approved these changes Nov 4, 2017

@lpinca

lpinca approved these changes Nov 5, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment

Trott added a commit to Trott/io.js that referenced this pull request Nov 18, 2017

tools: fail tests if malformed status file
PR-URL: nodejs#16703
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Nov 18, 2017

Member

Landed in 02590b4

Member

Trott commented Nov 18, 2017

Landed in 02590b4

@Trott Trott closed this Nov 18, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

tools: fail tests if malformed status file
PR-URL: #16703
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

MylesBorins added a commit that referenced this pull request Dec 19, 2017

tools: fail tests if malformed status file
PR-URL: #16703
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

gibfahn added a commit that referenced this pull request Dec 19, 2017

tools: fail tests if malformed status file
PR-URL: #16703
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

tools: fail tests if malformed status file
PR-URL: #16703
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

tools: fail tests if malformed status file
PR-URL: nodejs#16703
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment