Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: include src\tracing when linting on win #16720

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@danbev
Copy link
Member

commented Nov 3, 2017

This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build, windows

build: include src\tracing when linting on win
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.
@jasnell

jasnell approved these changes Nov 3, 2017

@Idenix

This comment has been minimized.

Copy link

commented Nov 5, 2017

@danbev

This comment has been minimized.

Copy link
Member Author

commented Nov 8, 2017

@danbev

This comment has been minimized.

Copy link
Member Author

commented Nov 8, 2017

test/arm-fanned failure looks unrelated

console output:

Reinitialized existing Git repository in /home/iojs/build/workspace/node-test-binary-arm/.git/
+ git fetch --no-tags file:///home/iojs/.ccache/node.shared.reference +refs/heads/master:refs/remotes/reference/master +refs/heads/v4.x-staging:refs/remotes/reference/v4.x-staging +refs/heads/v6.x-staging:refs/remotes/reference/v6.x-staging +refs/heads/v7.x-staging:refs/remotes/reference/v7.x-staging +refs/heads/v8.x-staging:refs/remotes/reference/v8.x-staging
fatal: Couldn't find remote ref refs/heads/v7.x-staging
fatal: The remote end hung up unexpectedly

real	0m13.370s
user	0m0.110s
sys	0m0.100s
+ echo 'Problem fetching the shared reference repo.'
Problem fetching the shared reference repo.
+ git fetch --no-tags file:///home/iojs/.ccache/node.shared.reference +refs/heads/jenkins-node-test-commit-arm-fanned-12403-binary-pi1p/cc-armv6:refs/remotes/jenkins_tmp
From file:///home/iojs/.ccache/node.shared.reference
 + 86687d80ff...64bed96866 jenkins-node-test-commit-arm-fanned-12403-binary-pi1p/cc-armv6 -> jenkins_tmp  (forced update)

real	0m42.005s
user	0m17.810s
sys	0m5.630s
+ rm -f ****
+ git checkout -f refs/remotes/jenkins_tmp
Warning: you are leaving 2 commits behind, not connected to
any of your branches:

  86687d80ff added binaries
  9213800a13 deps: ICU 60 bump

If you want to keep them by creating a new branch, this may be a good time
to do so with:

 git branch <new-branch-name> 86687d80ff

HEAD is now at 64bed96866... added binaries

real	0m37.907s
user	0m4.160s
sys	0m23.050s
+ git reset --hard
HEAD is now at 64bed96866 added binaries

real	0m12.236s
user	0m3.520s
sys	0m3.090s
+ git clean -fdx
warning: failed to remove out/Release/.nfs00000000002bfbf000000113: Device or resource busy
Removing config.gypi
Removing icu_config.gypi
Removing node
Removing out/Release/node
Removing out/Release/openssl-cli
Removing test.tap
Removing test/.tmp.0/
Removing test/abort/testcfg.pyc
Removing test/addons-napi/testcfg.pyc
Removing test/addons/testcfg.pyc
Removing test/async-hooks/testcfg.pyc
Removing test/doctool/testcfg.pyc
Removing test/es-module/testcfg.pyc
Removing test/gc/testcfg.pyc
Removing test/internet/testcfg.pyc
Removing test/known_issues/testcfg.pyc
Removing test/message/testcfg.pyc
Removing test/parallel/testcfg.pyc
Removing test/pseudo-tty/testcfg.pyc
Removing test/pummel/testcfg.pyc
Removing test/sequential/testcfg.pyc
Removing test/testpy/__init__.pyc
Removing test/tick-processor/testcfg.pyc
Removing test/timers/testcfg.pyc
Removing tools/test.pyc
Removing tools/utils.pyc
Build step 'Execute shell' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: *.tap
Did not find any matching files. Setting build result to FAILURE.
Checking ^not ok
Jenkins Text Finder: File set '*.tap' is empty
Notifying upstream projects of job completion
Finished: FAILURE
@danbev

This comment has been minimized.

Copy link
Member Author

commented Nov 8, 2017

@Trott

This comment has been minimized.

Copy link
Member

commented Nov 8, 2017

The problematic Raspberry Pi host has been disabled. Here's a re-run of Raspberry Pi CI: https://ci.nodejs.org/job/node-test-binary-arm/11625/

@danbev

This comment has been minimized.

Copy link
Member Author

commented Nov 9, 2017

Landed in f002c3d

@danbev danbev closed this Nov 9, 2017

danbev added a commit that referenced this pull request Nov 9, 2017

build: include src\tracing when linting on win
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.

PR-URL: #16720
Reviewed-By: James M Snell <jasnell@gmail.com>

@danbev danbev deleted the danbev:windows-lint-include-tracing branch Nov 9, 2017

evanlucas added a commit that referenced this pull request Nov 13, 2017

build: include src\tracing when linting on win
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.

PR-URL: #16720
Reviewed-By: James M Snell <jasnell@gmail.com>

@evanlucas evanlucas referenced this pull request Nov 13, 2017

Merged

v9.2.0 proposal #16992

MylesBorins added a commit that referenced this pull request Nov 17, 2017

build: include src\tracing when linting on win
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.

PR-URL: #16720
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

This comment has been minimized.

Copy link
Member

commented Nov 17, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

danbev added a commit to danbev/node that referenced this pull request Nov 21, 2017

build: include src\tracing when linting on win
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.

PR-URL: nodejs#16720
Reviewed-By: James M Snell <jasnell@gmail.com>

danbev added a commit to danbev/node that referenced this pull request Nov 21, 2017

build: include src\tracing when linting on win
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.

Refs: nodejs#16720
PR-URL: nodejs#16720
Reviewed-By: James M Snell <jasnell@gmail.com>

@gibfahn gibfahn referenced this pull request Nov 21, 2017

Merged

v8.9.2 proposal #17204

MylesBorins added a commit that referenced this pull request Nov 26, 2017

build: include src\tracing when linting on win
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.

Refs: #16720
Backport-PR-URL: #17172
PR-URL: #16720
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Nov 28, 2017

build: include src\tracing when linting on win
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.

Refs: #16720
Backport-PR-URL: #17172
PR-URL: #16720
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Nov 28, 2017

Merged

v6.12.1 proposal #17180

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

build: include src\tracing when linting on win
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.

PR-URL: nodejs#16720
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.