New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: use 'connect' event only if socket is connecting #16725

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@lpinca
Member

lpinca commented Nov 3, 2017

Fixes a bug that prevented ClientRequest.prototype.setTimeout() from
working properly when the socket was reused for multiple requests.

Fixes: #16716

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http

http: use 'connect' event only if socket is connecting
Fixes a bug that prevented `ClientRequest.prototype.setTimeout()` from
working properly when the socket was reused for multiple requests.

Fixes: #16716
Refs: #8895
@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Nov 6, 2017

Member

@nodejs/collaborators can you please take a look? It would be nice to have this fix in the next 9.x release.

Member

lpinca commented Nov 6, 2017

@nodejs/collaborators can you please take a look? It would be nice to have this fix in the next 9.x release.

@Trott

Trott approved these changes Nov 6, 2017

@jasnell

jasnell approved these changes Nov 6, 2017

@cjihrig

cjihrig approved these changes Nov 6, 2017

@lpinca

This comment has been minimized.

Show comment
Hide comment
@lpinca

lpinca Nov 6, 2017

Member

Landed in f60c692.

Member

lpinca commented Nov 6, 2017

Landed in f60c692.

@lpinca lpinca closed this Nov 6, 2017

lpinca added a commit that referenced this pull request Nov 6, 2017

http: use 'connect' event only if socket is connecting
Fixes a bug that prevented `ClientRequest.prototype.setTimeout()` from
working properly when the socket was reused for multiple requests.

Fixes: #16716
Refs: #8895
PR-URL: #16725
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

@lpinca lpinca deleted the lpinca:gh-16716 branch Nov 6, 2017

cjihrig added a commit to cjihrig/node-1 that referenced this pull request Nov 6, 2017

http: use 'connect' event only if socket is connecting
Fixes a bug that prevented `ClientRequest.prototype.setTimeout()` from
working properly when the socket was reused for multiple requests.

Fixes: nodejs#16716
Refs: nodejs#8895
PR-URL: nodejs#16725
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

@cjihrig cjihrig referenced this pull request Nov 6, 2017

Merged

v9.1.0 proposal #16851

cjihrig added a commit to cjihrig/node-1 that referenced this pull request Nov 7, 2017

2017-11-07, Version 9.1.0 (Current)
Notable changes:

* CLI:
  - NODE_OPTIONS now supports the --stack-trace-limit option.
    nodejs#16495
* deps:
  - OpenSSL is upgraded to 1.0.2m
    nodejs#16691
* http:
  - A 'connect' event handler leak has been fixed.
    nodejs#16725
  - The 103 Early Hints status code is now supported.
    nodejs#16644

PR-URL: nodejs#16851

cjihrig added a commit to cjihrig/node-1 that referenced this pull request Nov 7, 2017

2017-11-07, Version 9.1.0 (Current)
Notable changes:

* CLI:
  - NODE_OPTIONS now supports the --stack-trace-limit option.
    nodejs#16495
* deps:
  - OpenSSL is upgraded to 1.0.2m
    nodejs#16691
* http:
  - A 'connect' event handler leak has been fixed.
    nodejs#16725
  - The 103 Early Hints status code is now supported.
    nodejs#16644

PR-URL: nodejs#16851

cjihrig added a commit that referenced this pull request Nov 7, 2017

2017-11-07, Version 9.1.0 (Current)
Notable changes:

* CLI:
  - NODE_OPTIONS now supports the --stack-trace-limit option.
    #16495
* deps:
  - OpenSSL is upgraded to 1.0.2m
    #16691
* http:
  - A 'connect' event handler leak has been fixed.
    #16725
  - The 103 Early Hints status code is now supported.
    #16644

PR-URL: #16851

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

http: use 'connect' event only if socket is connecting
Fixes a bug that prevented `ClientRequest.prototype.setTimeout()` from
working properly when the socket was reused for multiple requests.

Fixes: nodejs#16716
Refs: nodejs#8895
PR-URL: nodejs#16725
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

2017-11-07, Version 9.1.0 (Current)
Notable changes:

* CLI:
  - NODE_OPTIONS now supports the --stack-trace-limit option.
    nodejs#16495
* deps:
  - OpenSSL is upgraded to 1.0.2m
    nodejs#16691
* http:
  - A 'connect' event handler leak has been fixed.
    nodejs#16725
  - The 103 Early Hints status code is now supported.
    nodejs#16644

PR-URL: nodejs#16851
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment