Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace common.fixturesDir with fixtures module #16803

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@doomhz
Copy link
Contributor

commented Nov 6, 2017

Require fixturesDir from fixtures module instead of common.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: replace common.fixturesDir with fixtures module
Require `fixturesDir` from `fixtures` module instead of `common`.
@cjihrig

cjihrig approved these changes Nov 6, 2017

@Trott

This comment has been minimized.

@Trott

Trott approved these changes Nov 6, 2017

Trott added a commit to Trott/io.js that referenced this pull request Nov 6, 2017

test: replace common.fixturesDir with fixtures module
Require `fixturesDir` from `fixtures` module instead of `common` in
test-fs-realpath-buffer-encoding.

PR-URL: nodejs#16803
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Nov 6, 2017

Landed in 4de1027.

Thanks for the contribution! 🎉

@Trott Trott closed this Nov 6, 2017

cjihrig added a commit to cjihrig/node-1 that referenced this pull request Nov 6, 2017

test: replace common.fixturesDir with fixtures module
Require `fixturesDir` from `fixtures` module instead of `common` in
test-fs-realpath-buffer-encoding.

PR-URL: nodejs#16803
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@cjihrig cjihrig referenced this pull request Nov 6, 2017

Merged

v9.1.0 proposal #16851

MylesBorins added a commit that referenced this pull request Nov 16, 2017

test: replace common.fixturesDir with fixtures module
Require `fixturesDir` from `fixtures` module instead of `common` in
test-fs-realpath-buffer-encoding.

PR-URL: #16803
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins added a commit that referenced this pull request Nov 16, 2017

test: replace common.fixturesDir with fixtures module
Require `fixturesDir` from `fixtures` module instead of `common` in
test-fs-realpath-buffer-encoding.

PR-URL: #16803
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@MylesBorins MylesBorins referenced this pull request Nov 21, 2017

Merged

v6.12.1 proposal #17180

@gibfahn gibfahn referenced this pull request Nov 21, 2017

Merged

v8.9.2 proposal #17204

MylesBorins added a commit that referenced this pull request Nov 21, 2017

test: replace common.fixturesDir with fixtures module
Require `fixturesDir` from `fixtures` module instead of `common` in
test-fs-realpath-buffer-encoding.

PR-URL: #16803
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins added a commit that referenced this pull request Nov 28, 2017

test: replace common.fixturesDir with fixtures module
Require `fixturesDir` from `fixtures` module instead of `common` in
test-fs-realpath-buffer-encoding.

PR-URL: #16803
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: replace common.fixturesDir with fixtures module
Require `fixturesDir` from `fixtures` module instead of `common` in
test-fs-realpath-buffer-encoding.

PR-URL: nodejs#16803
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.