Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update test to use fixtures.readKey #16811

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
8 participants
@darahayes
Copy link
Contributor

commented Nov 6, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines (leaving this unchecked because I'm not 100% sure - this is my first PR)
Affected core subsystem(s)

test: test/parallel/test-regress-GH-1531.js

@cjihrig

cjihrig approved these changes Nov 6, 2017

@@ -1,16 +1,19 @@
'use strict';
const common = require('../common');

// This test ensures that a http request callback is called
// when the agent option is set. See https://github.com/nodejs/node-v0.x-archive/issues/1531

This comment has been minimized.

Copy link
@cjihrig

cjihrig Nov 6, 2017

Contributor

Would you mind moving the See ... to a new line to stay under 80 characters.

This comment has been minimized.

Copy link
@darahayes

darahayes Nov 6, 2017

Author Contributor

@cjihrig No problem at all!

This comment has been minimized.

Copy link
@cjihrig

cjihrig Nov 6, 2017

Contributor

Thanks!

@Trott

This comment has been minimized.

@Trott

Trott approved these changes Nov 7, 2017

Trott added a commit to Trott/io.js that referenced this pull request Nov 7, 2017

test: update test to use fixtures.readKey
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-nodejsGH-1531.

PR-URL: nodejs#16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Nov 7, 2017

Landed in 207b24a.
Thanks for the contribution! 🎉

@Trott Trott closed this Nov 7, 2017

cjihrig added a commit to cjihrig/node-1 that referenced this pull request Nov 7, 2017

test: update test to use fixtures.readKey
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-nodejsGH-1531.

PR-URL: nodejs#16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@cjihrig cjihrig referenced this pull request Nov 7, 2017

Merged

v9.1.0 proposal #16851

MylesBorins added a commit that referenced this pull request Nov 16, 2017

test: update test to use fixtures.readKey
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-GH-1531.

PR-URL: #16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins added a commit that referenced this pull request Nov 16, 2017

test: update test to use fixtures.readKey
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-GH-1531.

PR-URL: #16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@MylesBorins MylesBorins referenced this pull request Nov 21, 2017

Merged

v6.12.1 proposal #17180

@gibfahn gibfahn referenced this pull request Nov 21, 2017

Merged

v8.9.2 proposal #17204

MylesBorins added a commit that referenced this pull request Nov 21, 2017

test: update test to use fixtures.readKey
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-GH-1531.

PR-URL: #16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins added a commit that referenced this pull request Nov 28, 2017

test: update test to use fixtures.readKey
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-GH-1531.

PR-URL: #16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: update test to use fixtures.readKey
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-nodejsGH-1531.

PR-URL: nodejs#16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.