New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test repl reset event #16836

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
9 participants
@AdriVanHoudt
Member

AdriVanHoudt commented Nov 6, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

AdriVanHoudt added some commits Nov 6, 2017

@AdriVanHoudt

This comment has been minimized.

Show comment
Hide comment
@AdriVanHoudt

AdriVanHoudt Nov 6, 2017

Member

I'm not super sure about the wording so any feedback welcome

Member

AdriVanHoudt commented Nov 6, 2017

I'm not super sure about the wording so any feedback welcome

@mscdex mscdex added the repl label Nov 6, 2017

@gireeshpunathil

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell approved these changes Nov 8, 2017

@AdriVanHoudt

This comment has been minimized.

Show comment
Hide comment
@AdriVanHoudt

AdriVanHoudt Dec 4, 2017

Member

@Trott I added a space at the end of every line, let me know if I need to squash this

Member

AdriVanHoudt commented Dec 4, 2017

@Trott I added a space at the end of every line, let me know if I need to squash this

@Trott

This comment has been minimized.

Show comment
Hide comment
@AdriVanHoudt

This comment has been minimized.

Show comment
Hide comment
@AdriVanHoudt

AdriVanHoudt Dec 4, 2017

Member

The space made line 47 to long 🤦‍♂️

Member

AdriVanHoudt commented Dec 4, 2017

The space made line 47 to long 🤦‍♂️

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Dec 4, 2017

Member

The space made line 47 to long 🤦‍♂️

😃 If you could wrap and fix, that would be great. (And if not, someone else like me can come along and do it when we're ready to land. But saving that person a few keystrokes and some time would be great.)

Member

Trott commented Dec 4, 2017

The space made line 47 to long 🤦‍♂️

😃 If you could wrap and fix, that would be great. (And if not, someone else like me can come along and do it when we're ready to land. But saving that person a few keystrokes and some time would be great.)

@AdriVanHoudt

This comment has been minimized.

Show comment
Hide comment
@AdriVanHoudt

AdriVanHoudt Dec 5, 2017

Member

Do you mean splitting the string in 3 parts instead of the current 2? I feel like eslint should be able to fix this 🙃

Member

AdriVanHoudt commented Dec 5, 2017

Do you mean splitting the string in 3 parts instead of the current 2? I feel like eslint should be able to fix this 🙃

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Dec 5, 2017

Member

Do you mean splitting the string in 3 parts instead of the current 2?

Easiest fix is probably to remove the comma after context on line 47.

I feel like eslint should be able to fix this 🙃

ESLint docs indicate max-len is not a rule that can be auto-fixed.

Member

Trott commented Dec 5, 2017

Do you mean splitting the string in 3 parts instead of the current 2?

Easiest fix is probably to remove the comma after context on line 47.

I feel like eslint should be able to fix this 🙃

ESLint docs indicate max-len is not a rule that can be auto-fixed.

@AdriVanHoudt

This comment has been minimized.

Show comment
Hide comment
@AdriVanHoudt

AdriVanHoudt Dec 6, 2017

Member

ESLint docs indicate max-len is not a rule that can be auto-fixed.

Ok that rule does more than I expected, shortsighted comment from me sorry

I updated the line, so let's hope it is good now

Member

AdriVanHoudt commented Dec 6, 2017

ESLint docs indicate max-len is not a rule that can be auto-fixed.

Ok that rule does more than I expected, shortsighted comment from me sorry

I updated the line, so let's hope it is good now

@Trott

This comment has been minimized.

Show comment
Hide comment

apapirovski added a commit that referenced this pull request Dec 9, 2017

test: improve assert messages in repl-reset-event
PR-URL: #16836
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@apapirovski

This comment has been minimized.

Show comment
Hide comment
@apapirovski

apapirovski Dec 9, 2017

Member

Landed in bbcbcb8

Thank you for the contribution @AdriVanHoudt!

Member

apapirovski commented Dec 9, 2017

Landed in bbcbcb8

Thank you for the contribution @AdriVanHoudt!

@apapirovski apapirovski closed this Dec 9, 2017

@AdriVanHoudt AdriVanHoudt deleted the AdriVanHoudt:test-repl-reset-event branch Dec 11, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: improve assert messages in repl-reset-event
PR-URL: #16836
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

test: improve assert messages in repl-reset-event
PR-URL: #16836
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: improve assert messages in repl-reset-event
PR-URL: #16836
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: improve assert messages in repl-reset-event
PR-URL: #16836
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

test: improve assert messages in repl-reset-event
PR-URL: #16836
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 5, 2018

test: improve assert messages in repl-reset-event
PR-URL: nodejs#16836
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: improve assert messages in repl-reset-event
PR-URL: nodejs#16836
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment