Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix a link in dgram.md #16854

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@vsemozhetbyt
Copy link
Contributor

commented Nov 7, 2017

Checklist
Affected core subsystem(s)

doc, dgram

@vsemozhetbyt vsemozhetbyt changed the title doc: fox a link in dgram.md doc: fix a link in dgram.md Nov 7, 2017

@vsemozhetbyt vsemozhetbyt force-pushed the vsemozhetbyt:fix-links-20171107 branch from 17e140b to 3c28fc5 Nov 7, 2017

@@ -629,7 +629,7 @@ and `udp6` sockets). The bound address and port can be retrieved using
[`socket.address().address`]: #dgram_socket_address
[`socket.address().port`]: #dgram_socket_address
[`socket.bind()`]: #dgram_socket_bind_port_address_callback
[`System Error`]: errors.html#errors_class_system_error
[`System Error`]: errors.html#errors_class_systemerror

This comment has been minimized.

Copy link
@lpinca

lpinca Nov 7, 2017

Member

On second look errors.html#errors_class_system_error seems correct.

@lpinca lpinca dismissed their stale review Nov 7, 2017

Link seems correct.

@lpinca

lpinca approved these changes Nov 7, 2017

vsemozhetbyt added a commit to vsemozhetbyt/node that referenced this pull request Nov 7, 2017

doc: fix a link in dgram.md
PR-URL: nodejs#16854
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Nov 7, 2017

Landed in 83fcb9f

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:fix-links-20171107 branch Nov 7, 2017

cjihrig added a commit to cjihrig/node-1 that referenced this pull request Nov 7, 2017

doc: fix a link in dgram.md
PR-URL: nodejs#16854
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@cjihrig cjihrig referenced this pull request Nov 7, 2017

Merged

v9.1.0 proposal #16851

MylesBorins added a commit that referenced this pull request Nov 16, 2017

doc: fix a link in dgram.md
PR-URL: #16854
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@gibfahn gibfahn referenced this pull request Nov 21, 2017

Merged

v8.9.2 proposal #17204

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

doc: fix a link in dgram.md
PR-URL: nodejs#16854
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.