New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tty, test: refactor exports and add coverage #16959

Merged
merged 2 commits into from Nov 14, 2017

Conversation

Projects
None yet
6 participants
@cjihrig
Contributor

cjihrig commented Nov 12, 2017

This PR updates the tty module's exports to be more aligned with other core modules. It also adds test coverage (I believe to 100%).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

tty, test

@cjihrig

This comment has been minimized.

Show comment
Hide comment
Contributor

cjihrig commented Nov 14, 2017

cjihrig added some commits Nov 12, 2017

tty: refactor exports
This commit moves the tty module's exports to a single object,
which is more aligned with other core modules.

PR-URL: #16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
test: add coverage to tty module
PR-URL: #16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@cjihrig

This comment has been minimized.

Show comment
Hide comment
@cjihrig

cjihrig Nov 14, 2017

Contributor

CI failures appear unrelated.

Contributor

cjihrig commented Nov 14, 2017

CI failures appear unrelated.

@cjihrig cjihrig merged commit 4b5a816 into nodejs:master Nov 14, 2017

1 check passed

test/linux tests passed
Details

@cjihrig cjihrig deleted the cjihrig:tty branch Nov 14, 2017

MylesBorins added a commit that referenced this pull request Dec 11, 2017

tty: refactor exports
This commit moves the tty module's exports to a single object,
which is more aligned with other core modules.

PR-URL: #16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins added a commit that referenced this pull request Dec 11, 2017

test: add coverage to tty module
PR-URL: #16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

gibfahn added a commit that referenced this pull request Dec 13, 2017

tty: refactor exports
This commit moves the tty module's exports to a single object,
which is more aligned with other core modules.

PR-URL: #16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

gibfahn added a commit that referenced this pull request Dec 13, 2017

test: add coverage to tty module
PR-URL: #16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

gibfahn added a commit that referenced this pull request Dec 13, 2017

tty: refactor exports
This commit moves the tty module's exports to a single object,
which is more aligned with other core modules.

PR-URL: #16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

gibfahn added a commit that referenced this pull request Dec 13, 2017

test: add coverage to tty module
PR-URL: #16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Dec 13, 2017

Member

@cjihrig this one was two commits, please do the

Landed in 8ae4e1c 4b5a816

thing.

Member

gibfahn commented Dec 13, 2017

@cjihrig this one was two commits, please do the

Landed in 8ae4e1c 4b5a816

thing.

This was referenced Dec 20, 2017

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

tty: refactor exports
This commit moves the tty module's exports to a single object,
which is more aligned with other core modules.

PR-URL: nodejs#16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

test: add coverage to tty module
PR-URL: nodejs#16959
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment