New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,win: clarify WSL support #17008

Closed
wants to merge 2 commits into
base: master
from

Conversation

@joaocgreis
Member

joaocgreis commented Nov 14, 2017

Following the discussion in #13471, this adds a note to BUILDING.md to clarify WSL support.

cc @nodejs/platform-windows @nodejs/build

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc, win

@joaocgreis

This comment has been minimized.

Show comment
Hide comment
Show outdated Hide outdated BUILDING.md
Show outdated Hide outdated BUILDING.md
Show outdated Hide outdated BUILDING.md
@joaocgreis

This comment has been minimized.

Show comment
Hide comment
@joaocgreis

joaocgreis Nov 15, 2017

Member

Addressed feedback, PTAL.

@TimothyGu @refack Windows binaries should work in WSL, so saying it's not supported is too strong. We don't want to work around bugs in WSL, but if it can provide a valid Windows environment it should work. I've left the "is not recommended", should be clear enough.

Member

joaocgreis commented Nov 15, 2017

Addressed feedback, PTAL.

@TimothyGu @refack Windows binaries should work in WSL, so saying it's not supported is too strong. We don't want to work around bugs in WSL, but if it can provide a valid Windows environment it should work. I've left the "is not recommended", should be clear enough.

joaocgreis added a commit that referenced this pull request Nov 17, 2017

doc,win: clarify WSL support
Fixes: #13471
PR-URL: #17008
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@joaocgreis

This comment has been minimized.

Show comment
Hide comment
@joaocgreis

joaocgreis Nov 17, 2017

Member

Landed in d8debd8

Member

joaocgreis commented Nov 17, 2017

Landed in d8debd8

@joaocgreis joaocgreis closed this Nov 17, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc,win: clarify WSL support
Fixes: #13471
PR-URL: #17008
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

gibfahn added a commit that referenced this pull request Dec 19, 2017

doc,win: clarify WSL support
Fixes: #13471
PR-URL: #17008
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Dec 19, 2017

Member

@nodejs/build @nodejs/platform-windows I backported this to v8.x-staging and v6.x-staging, as I think the support statement is true for LTS lines as well. If anyone disagrees LMK.

Member

gibfahn commented Dec 19, 2017

@nodejs/build @nodejs/platform-windows I backported this to v8.x-staging and v6.x-staging, as I think the support statement is true for LTS lines as well. If anyone disagrees LMK.

MylesBorins added a commit that referenced this pull request Dec 19, 2017

doc,win: clarify WSL support
Fixes: #13471
PR-URL: #17008
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@gibfahn gibfahn added land-on-v8.x and removed land-on-v6.x labels Dec 19, 2017

@bzoz

This comment has been minimized.

Show comment
Hide comment
@bzoz

bzoz Dec 19, 2017

Contributor

SGTM

Contributor

bzoz commented Dec 19, 2017

SGTM

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc,win: clarify WSL support
Fixes: #13471
PR-URL: #17008
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

doc,win: clarify WSL support
Fixes: nodejs#13471
PR-URL: nodejs#17008
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@refack refack referenced this pull request Oct 13, 2018

Closed

doc: edit BUILDING.md #23435

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment