New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve collaborator guide, doc fast-tracking process #17056

Closed
wants to merge 5 commits into
base: master
from

Conversation

@joyeecheung
Member

joyeecheung commented Nov 15, 2017

doc: reorganize collaborator guide

  • Add sections about first time contributions, code reviews
    and seeking consensus, waiting for approvals, testing and CI
  • Move paragraphs to more suitable sections
  • Update table of contents

doc: document the fast-tracking process

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

joyeecheung added some commits Nov 15, 2017

doc: reorganize collaborator guide
* Add sections about first time contributions, code reviews
  and seeking consensus, waiting for approvals, testing and CI
* Move paragraphs to more suitable sections
* Update table of contents
Show outdated Hide outdated COLLABORATOR_GUIDE.md Outdated
@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@joyeecheung
Member

joyeecheung commented Nov 15, 2017

Show outdated Hide outdated COLLABORATOR_GUIDE.md Outdated
Show outdated Hide outdated COLLABORATOR_GUIDE.md Outdated
Show outdated Hide outdated COLLABORATOR_GUIDE.md Outdated
Show outdated Hide outdated COLLABORATOR_GUIDE.md Outdated
Show outdated Hide outdated COLLABORATOR_GUIDE.md Outdated
Show outdated Hide outdated COLLABORATOR_GUIDE.md Outdated
Show outdated Hide outdated COLLABORATOR_GUIDE.md Outdated

joyeecheung added some commits Nov 16, 2017

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@joyeecheung

joyeecheung Nov 16, 2017

Member

@mcollina @addaleax @gibfahn @refack I've moved the paragraphs a bit, deleted the bug-fix and optimization examples, and changed the number of required approvals to 2 (I've taken a look into the recent fast-tracked PRs and I think 2 should be safe enough. We can always revert if someone objects later). PTAL.

Member

joyeecheung commented Nov 16, 2017

@mcollina @addaleax @gibfahn @refack I've moved the paragraphs a bit, deleted the bug-fix and optimization examples, and changed the number of required approvals to 2 (I've taken a look into the recent fast-tracked PRs and I think 2 should be safe enough. We can always revert if someone objects later). PTAL.

Show outdated Hide outdated COLLABORATOR_GUIDE.md Outdated
@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@joyeecheung

joyeecheung Nov 17, 2017

Member

@tniessen Updated to 2 or more collaborators and added a sentence about CI is still required for fast-track PRs (it's pretty obvious, but still should be mentioned )

Member

joyeecheung commented Nov 17, 2017

@tniessen Updated to 2 or more collaborators and added a sentence about CI is still required for fast-track PRs (it's pretty obvious, but still should be mentioned )

@mhdawson

LGTM

@joyeecheung

This comment has been minimized.

Show comment
Hide comment
@joyeecheung

joyeecheung Nov 18, 2017

Member

Landed as 0a1fba0, thanks!

Member

joyeecheung commented Nov 18, 2017

Landed as 0a1fba0, thanks!

joyeecheung added a commit that referenced this pull request Nov 18, 2017

doc: reorganize collaborator guide
* Add sections about first time contributions, code reviews
  and seeking consensus, waiting for approvals, testing and CI
* Move paragraphs to more suitable sections
* Update table of contents
* Document the fast-tracking process

PR-URL: #17056
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

@joyeecheung joyeecheung added the meta label Nov 18, 2017

@vsemozhetbyt vsemozhetbyt referenced this pull request Nov 18, 2017

Closed

Todo: Skip the wait check for specific PRs #94

0 of 2 tasks complete

@refack refack referenced this pull request Nov 26, 2017

Merged

doc: clarify fast-track of reversions #17332

2 of 2 tasks complete

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: reorganize collaborator guide
* Add sections about first time contributions, code reviews
  and seeking consensus, waiting for approvals, testing and CI
* Move paragraphs to more suitable sections
* Update table of contents
* Document the fast-tracking process

PR-URL: #17056
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

MylesBorins added a commit that referenced this pull request Dec 19, 2017

doc: reorganize collaborator guide
* Add sections about first time contributions, code reviews
  and seeking consensus, waiting for approvals, testing and CI
* Move paragraphs to more suitable sections
* Update table of contents
* Document the fast-tracking process

PR-URL: #17056
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

gibfahn added a commit that referenced this pull request Dec 19, 2017

doc: reorganize collaborator guide
* Add sections about first time contributions, code reviews
  and seeking consensus, waiting for approvals, testing and CI
* Move paragraphs to more suitable sections
* Update table of contents
* Document the fast-tracking process

PR-URL: #17056
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: reorganize collaborator guide
* Add sections about first time contributions, code reviews
  and seeking consensus, waiting for approvals, testing and CI
* Move paragraphs to more suitable sections
* Update table of contents
* Document the fast-tracking process

PR-URL: #17056
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

doc: reorganize collaborator guide
* Add sections about first time contributions, code reviews
  and seeking consensus, waiting for approvals, testing and CI
* Move paragraphs to more suitable sections
* Update table of contents
* Document the fast-tracking process

PR-URL: nodejs#17056
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment