New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: minor corrections to configure descriptions #17094

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
8 participants
@danbev
Member

danbev commented Nov 17, 2017

This commit updates --enable-vtune-profiling from:

Enable profiling support for Intel VTune profiler to
profileJavaScript code executed in nodejs.

to:

Enable profiling support for Intel VTune profiler to
profile JavaScript code executed in nodejs.

And --link-module=LINKED_MODULE from:

Path to a JS file to be bundled in the binary as a
builtin.This module will be referenced by path without
extension.e.g. /root/x/y.js will be referenced via

to:

Path to a JS file to be bundled in the binary as a
builtin. This module will be referenced by path
without extension; e.g. /root/x/y.js will be
referenced via require('root/x/y').
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

@lpinca

lpinca approved these changes Nov 17, 2017

@richardlau

This comment has been minimized.

Show comment
Hide comment
@richardlau

richardlau Nov 17, 2017

Member

FWIW, @vsemozhetbyt identified other corrections to the configure help text in #16975. I'll leave it up to @danbev as to whether to include those here with these changes or to leave for another PR.

Member

richardlau commented Nov 17, 2017

FWIW, @vsemozhetbyt identified other corrections to the configure help text in #16975. I'll leave it up to @danbev as to whether to include those here with these changes or to leave for another PR.

@richardlau richardlau referenced this pull request Nov 17, 2017

Closed

doc: add guide on maintaining the build files #16975

2 of 4 tasks complete
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Nov 18, 2017

Member

Landed in 6c5a39c

Member

addaleax commented Nov 18, 2017

Landed in 6c5a39c

@addaleax addaleax closed this Nov 18, 2017

addaleax added a commit that referenced this pull request Nov 18, 2017

build: minor corrections to configure descriptions
PR-URL: #17094
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

build: minor corrections to configure descriptions
PR-URL: #17094
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

gibfahn added a commit that referenced this pull request Dec 19, 2017

build: minor corrections to configure descriptions
PR-URL: #17094
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins added a commit that referenced this pull request Dec 19, 2017

build: minor corrections to configure descriptions
PR-URL: #17094
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@gibfahn gibfahn added land-on-v8.x and removed land-on-v6.x labels Dec 19, 2017

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

build: minor corrections to configure descriptions
PR-URL: #17094
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

msoechting added a commit to hpicgs/node that referenced this pull request Feb 7, 2018

build: minor corrections to configure descriptions
PR-URL: nodejs#17094
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@danbev danbev deleted the danbev:configure-help-corrections branch Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment