New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: multiple README fixes #17106

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
10 participants
@Trott
Member

Trott commented Nov 17, 2017

The IRC link is mentioned in CONTRIBUTING.md which is linked immediately
above. We should encourage people to read that doc before hoping on the
IRC channel.

Refs: #16533 (comment)

Merge Working Groups with Contributing to Node.js.

Add Contributing to Node.js to the ToC and set it's heading level accordingly.

Normalize the ToC indentation with heading levels.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott
Member

Trott commented Nov 17, 2017

Trott added some commits Nov 17, 2017

doc: remove IRC node-dev link from README
The IRC link is mentioned in CONTRIBUTING.md which is linked immediately
above. We should encourage people to read that doc before hoping on the
IRC channel.

Refs: #16533 (comment)

@Trott Trott changed the title from doc: remove IRC node-dev link from README to doc: multiple README fixes Nov 17, 2017

@refack

refack approved these changes Nov 17, 2017

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Nov 18, 2017

Member

(CI is good.)

Member

Trott commented Nov 18, 2017

(CI is good.)

@lpinca

lpinca approved these changes Nov 18, 2017

@mhdawson

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Nov 20, 2017

doc: remove IRC node-dev link from README
The IRC link is mentioned in CONTRIBUTING.md which is linked immediately
above. We should encourage people to read that doc before hoping on the
IRC channel.

PR-URL: nodejs#17106
Ref: nodejs#16533 (comment)
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Trott added a commit to Trott/io.js that referenced this pull request Nov 20, 2017

doc: merge Working Groups with Contributing to Node.js in README
PR-URL: nodejs#17106
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Trott added a commit to Trott/io.js that referenced this pull request Nov 20, 2017

doc: add Contributing to Node.js to the README ToC
PR-URL: nodejs#17106
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Trott added a commit to Trott/io.js that referenced this pull request Nov 20, 2017

doc: normalize ToC indentation with heading levels in README
PR-URL: nodejs#17106
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Nov 20, 2017

Member

Landed in 545a789, 67af8d8, 345bfd8, and 65439b4.

Member

Trott commented Nov 20, 2017

Landed in 545a789, 67af8d8, 345bfd8, and 65439b4.

@Trott Trott closed this Nov 20, 2017

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: remove IRC node-dev link from README
The IRC link is mentioned in CONTRIBUTING.md which is linked immediately
above. We should encourage people to read that doc before hoping on the
IRC channel.

PR-URL: #17106
Ref: #16533 (comment)
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: merge Working Groups with Contributing to Node.js in README
PR-URL: #17106
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: add Contributing to Node.js to the README ToC
PR-URL: #17106
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request Dec 12, 2017

doc: normalize ToC indentation with heading levels in README
PR-URL: #17106
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@MylesBorins MylesBorins referenced this pull request Dec 12, 2017

Merged

v9.3.0 proposal #17631

MylesBorins added a commit that referenced this pull request Dec 19, 2017

doc: remove IRC node-dev link from README
The IRC link is mentioned in CONTRIBUTING.md which is linked immediately
above. We should encourage people to read that doc before hoping on the
IRC channel.

PR-URL: #17106
Ref: #16533 (comment)
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request Dec 19, 2017

doc: merge Working Groups with Contributing to Node.js in README
PR-URL: #17106
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request Dec 19, 2017

doc: add Contributing to Node.js to the README ToC
PR-URL: #17106
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

MylesBorins added a commit that referenced this pull request Dec 19, 2017

doc: normalize ToC indentation with heading levels in README
PR-URL: #17106
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

gibfahn added a commit that referenced this pull request Dec 19, 2017

doc: remove IRC node-dev link from README
The IRC link is mentioned in CONTRIBUTING.md which is linked immediately
above. We should encourage people to read that doc before hoping on the
IRC channel.

PR-URL: #17106
Ref: #16533 (comment)
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

gibfahn added a commit that referenced this pull request Dec 19, 2017

doc: merge Working Groups with Contributing to Node.js in README
PR-URL: #17106
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

gibfahn added a commit that referenced this pull request Dec 19, 2017

doc: add Contributing to Node.js to the README ToC
PR-URL: #17106
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

gibfahn added a commit that referenced this pull request Dec 19, 2017

doc: normalize ToC indentation with heading levels in README
PR-URL: #17106
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Closed

v8.9.4 proposal #17772

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: remove IRC node-dev link from README
The IRC link is mentioned in CONTRIBUTING.md which is linked immediately
above. We should encourage people to read that doc before hoping on the
IRC channel.

PR-URL: #17106
Ref: #16533 (comment)
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: merge Working Groups with Contributing to Node.js in README
PR-URL: #17106
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: add Contributing to Node.js to the README ToC
PR-URL: #17106
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

gibfahn added a commit that referenced this pull request Dec 20, 2017

doc: normalize ToC indentation with heading levels in README
PR-URL: #17106
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@gibfahn gibfahn referenced this pull request Dec 20, 2017

Merged

v8.9.4 proposal #17774

@MylesBorins MylesBorins referenced this pull request Dec 20, 2017

Merged

v6.12.3 proposal #17776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment